Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an admin to specify Che default editor and containers #21353

Closed
Tracked by #21395 ...
l0rd opened this issue Apr 27, 2022 · 7 comments · Fixed by eclipse-che/che-dashboard#567
Closed
Tracked by #21395 ...

Allow an admin to specify Che default editor and containers #21353

l0rd opened this issue Apr 27, 2022 · 7 comments · Fixed by eclipse-che/che-dashboard#567
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/dashboard kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Apr 27, 2022

Is your enhancement related to a problem? Please describe

If no devfile is present in a git repository the default is to start a workspace with only one component (the Theia container) and Theia as the editor.

That's a bad UX as the Theia container misses many langue tools and because an admin cannot change this behavior.

Describe the solution you'd like

The default container should be a UDI container. Both the default container and the default editor should be configurable in the CheCluster CR.

(...)
workspaces:
  (...)
  defaultComponent or defaultContainer ?: |
    name: universal-developer-image
    container:
        image: quay.io/devfile/universal-developer-image:ubi8-latest
        memoryRequest: 256M
        memoryLimit: 1536M
        cpuRequest: 0.1
        cpuLimit: 0.5
  defaultEditor: eclipse/che-theia/next
(...)

Additional Context

This is a #21340 subtask.

Release Notes Text

Che administrators can now configure the default editor (Theia, VS Code, IntelliJ or PyCharm) and the default container. Those defaults are used when the developer doesn't specify an editor or doesn't specify a devfile. The configuration can be done in the CheCluster Custom Resource in the the workspaces section using the just introduced defaultComponent and defaultEditor fields.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Apr 27, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 27, 2022
@l0rd l0rd added area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/dashboard and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 27, 2022
@ibuziuk ibuziuk added the severity/P1 Has a major impact to usage or development of the system. label Apr 27, 2022
@ibuziuk ibuziuk mentioned this issue Apr 27, 2022
58 tasks
@ibuziuk ibuziuk mentioned this issue May 16, 2022
49 tasks
@olexii4 olexii4 self-assigned this May 16, 2022
@amisevsk
Copy link
Contributor

Another option for the new field in the CR is to use []devfile.Component rather than string. This would enable k8s validation of the field, devfile/api docs/autocomplete, etc. but would have the downside of making the CheCluster CR quite a bit bigger.

(...)
workspaces:
  (...)
  defaultComponents:
    - name: universal-developer-image
      container:
          image: quay.io/devfile/universal-developer-image:ubi8-latest
          memoryRequest: 256M
          memoryLimit: 1536M
          cpuRequest: 0.1
          cpuLimit: 0.5
    - name: some-volume
      volume: {}
  defaultEditor: eclipse/che-theia/next
(...)

The benefit of this approach would be that since both the Che Operator and Dashboard depend on devfile/api already, these components could be easily deserialized by both as needed and just added to empty devfiles directly, under .components

@l0rd
Copy link
Contributor Author

l0rd commented Jun 23, 2022

@olexii4 the che operator PR has been merged and I am wondering why this issue is still open. Is it because you are working on a dashboard PR? I am asking because we would like to include it in the new and noteworthy features of this release.

@olexii4
Copy link
Contributor

olexii4 commented Jun 23, 2022

feat: support workspace defaults eclipse-che/che-operator#1395

PR was merged yesterday in the evening. I waited until the next image has built. I tried to test it. Today I have deployed CHE on minikube but cannot see changes that should be in che-operator. I am investigating the problem.

I will do my best to do it ASAP.

@ibuziuk ibuziuk mentioned this issue Jun 27, 2022
68 tasks
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jun 30, 2022
@l0rd l0rd added this to the 7.50 milestone Jun 30, 2022
@l0rd l0rd added the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jun 30, 2022
@l0rd l0rd changed the title Add workspaces default editor and component in CheCluster CRD Allow an admin to specify Che default editor and containers Jun 30, 2022
@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
@nickboldt
Copy link
Contributor

add comment to reset sync date, so we should get a new message here that collects the PRs.

@nickboldt nickboldt reopened this Jan 17, 2023
@nickboldt
Copy link
Contributor

comemnt

@amisevsk
Copy link
Contributor

The beauty of automation 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/dashboard kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants