Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster workspace startup as a result of avoiding changes to DevWorkspace CR after it has started #21664

Closed
ibuziuk opened this issue Aug 26, 2022 · 7 comments · Fixed by eclipse-che/che-dashboard#621
Closed

Faster workspace startup as a result of avoiding changes to DevWorkspace CR after it has started #21664

ibuziuk opened this issue Aug 26, 2022 · 7 comments · Fixed by eclipse-che/che-dashboard#621
Assignees
@ibuziuk
Labels
area/dashboard area/hosted-che kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes sprint/current
Milestone
7.54

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Aug 26, 2022 •
edited by l0rd
Loading

Describe the bug

During startup looks like dashboard is patching DevWorkspace which results in replica set being scaled down resulting in a much slower workspace startup
image
the

Che version

7.50

Steps to reproduce

  1. Go to workspaces.openshift.com
  2. Start a workspace from getting started samples of via factory
  3. open OpenShift events
  4. ERROR: see that replica set is scaled up and down within a short time frame (less than 1 minute)

Expected behavior

replica set is scaled up once during workspace startup

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Dev Sandbox (workspaces.openshift.com)

Release Notes Text

The startup times of workspaces that have a persistent volume attached (the default) has been significantly improved.
@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/dashboard area/hosted-che labels Aug 26, 2022
@ibuziuk ibuziuk changed the title Dashboard should not patch DevWorkspace during startup (replica set is scaling up and down resulting in slow workspace startup)) Dashboard should not patch DevWorkspace during startup (replica set is scaling up and down resulting in slow workspace startup) Aug 26, 2022
@ibuziuk ibuziuk mentioned this issue Aug 26, 2022
Closed
82 tasks
@olexii4 olexii4 self-assigned this Aug 31, 2022
@olexii4 olexii4 mentioned this issue Sep 5, 2022
Merged
@olexii4 olexii4 mentioned this issue Sep 14, 2022
Merged
@l0rd l0rd changed the title Dashboard should not patch DevWorkspace during startup (replica set is scaling up and down resulting in slow workspace startup) Faster workspace startup as a result of avoiding changes to DevWorkspace CR after it has started Sep 15, 2022
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Sep 15, 2022
@l0rd l0rd added this to the 7.54 milestone Sep 15, 2022
@ibuziuk ibuziuk reopened this Oct 21, 2022
@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 21, 2022

@olexii4 I was able to reproduce the issue on Dev Spaces 3.2 even though the fix was backported - eclipse-che/che-dashboard#626

Please, find the events when an alternative editor (VSCode) is selected for Getting Started samples

image

@ibuziuk ibuziuk mentioned this issue Nov 22, 2022
Closed
68 tasks
@ibuziuk ibuziuk added sprint/current and removed sprint/next severity/P1 Has a major impact to usage or development of the system. labels Nov 22, 2022
@olexii4
Copy link
Contributor

olexii4 commented Nov 27, 2022 •
edited
Loading

@ibuziuk I cannot reproduce it.
I have checked all requests from the UD and they are fine:
2022-11-27_1
2022-11-27_2
2022-11-27_3
2022-11-27_4
2022-11-27_5
Events are good too:
2022-11-27_6
2022-11-27_7
2022-11-27_8
My created workspace:
2022-11-27_9

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 28, 2022

thanks, let's close in this case
will verify again on 3.3 once it is promoted to Developer Sandbox

@ibuziuk ibuziuk closed this as completed Nov 28, 2022
@ibuziuk ibuziuk reopened this Dec 15, 2022
@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 15, 2022

@olexii4 it seems that in 3.3 on workspaces.openshift.com we still have this behavior when starting getting-started samples:

image

Reproduced with NodeJs MongoDB

@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 9, 2023
@ibuziuk ibuziuk mentioned this issue Mar 21, 2023
Closed
50 tasks
@ibuziuk ibuziuk assigned ibuziuk and unassigned ibuziuk and olexii4 Mar 21, 2023
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 21, 2023

Need to verify again after workspaces.openshift.com upgrades to 3.5 and close if not reproducible

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 22, 2023

Verified against workspaces.openshift.com Closing

@ibuziuk ibuziuk closed this as completed Mar 22, 2023
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibuziuk ibuziuk

Labels
area/dashboard area/hosted-che kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes sprint/current
Projects
None yet
Milestone
7.54
Development

Successfully merging a pull request may close this issue.

Prevent patching DevWorkspace during startup eclipse-che/che-dashboard
5 participants
@l0rd @ibuziuk @olexii4 @devstudio-release @max-cx