Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevWorkspaces generated in che-devfile-registry build should use container contributions #21832

Closed
l0rd opened this issue Nov 22, 2022 · 0 comments
Closed

DevWorkspaces generated in che-devfile-registry build should use container contributions #21832

l0rd opened this issue Nov 22, 2022 · 0 comments
Assignees
@svor
Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Nov 22, 2022 •
edited
Loading

Is your enhancement related to a problem? Please describe

The che-devfile-registry builds pre-generates some devworkspace and devworkspacetemplates but still uses plugins when referencing editors and doesn't take advantage of container contributions.

Describe the solution you'd like

We should replace the usage of vscode and theia handlers when generating the devworkspaces and:

  1. reference editors using spec.contributions rather than spec.template.components in DevWorkspaces definitions.
  2. Use components with attribute controller.devfile.io/container-contribution: true rather than patching the original devfile spec in editors DevWorkspaceTemplates defintitions.

Additional context

This is part of #21736
@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. area/devfile-registry labels Nov 22, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 22, 2022
@l0rd l0rd mentioned this issue Nov 22, 2022
Closed
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 22, 2022
@ibuziuk ibuziuk mentioned this issue Nov 22, 2022
Closed
68 tasks
@svor svor mentioned this issue Dec 7, 2022
Closed
@svor svor self-assigned this Dec 9, 2022
This was referenced Dec 9, 2022
Merged
Closed
@svor svor closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svor svor

Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@l0rd @svor @che-bot