Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid startup failures on Developer Sandbox because of route counts quota #22069

Closed
l0rd opened this issue Mar 17, 2023 · 4 comments
Closed

Avoid startup failures on Developer Sandbox because of route counts quota #22069

l0rd opened this issue Mar 17, 2023 · 4 comments
Assignees
Labels
area/hosted-che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. status/validated The issue resolution has been validated
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 17, 2023

Is your enhancement related to a problem? Please describe

Quotas are configured on developer sandbox and it's not possible to have an arbitrary number of workspaces on developer sandbox. In particular routes count (30) will cause startup failures if a certain number of workspaces (9) exist, even if the workspaces are stopped.

And usually developers don't have any clue of what's going on (apart that Dev Spaces is broken) when that happens.

Describe the solution you'd like

Set maxNumberOfWorkspacesPerUser to 5 on developer sandbox.

Note that currently user should not be able to create more than 4 workspaces because of #22068 (4th workspace fails). This problem has been introduced with the update to 3.4. That means setting maxNumberOfWorkspacesPerUser: 5 should not require users to delete existing workspaces. But that will change when the quota is going to be updated.

Alternative solution

Set config.workspace.cleanupOnStop: true so that routes of stopped workspaces are deleted.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 17, 2023
@l0rd l0rd changed the title Limit the total number of workspace on Developer Sandbox Limit the max number of workspace per user on Developer Sandbox Mar 17, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 17, 2023
@l0rd l0rd added area/hosted-che severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 17, 2023
@ibuziuk ibuziuk self-assigned this Mar 17, 2023
@ibuziuk ibuziuk mentioned this issue Mar 17, 2023
50 tasks
@ibuziuk ibuziuk added this to the 7.64 milestone Apr 5, 2023
@ibuziuk
Copy link
Member

ibuziuk commented Apr 6, 2023

Instead of restricting the number of workspaces cleanupOnStop option on DWOC level has been enabled on Developer Sandbox stg and production clusters (svc, routes are removed once workspace is stopped)

config:
  workspace:
    cleanupOnStop: true

@ibuziuk ibuziuk closed this as completed Apr 6, 2023
@l0rd
Copy link
Contributor Author

l0rd commented Apr 6, 2023

Instead of restricting the number of workspaces cleanupOnStop option on DWOC level has been enabled on Developer Sandbox stg and production clusters (svc, routes are removed once workspace is stopped)

This may have an effect on performances. I though we would have enabled that in our dev environment first.

@ibuziuk
Copy link
Member

ibuziuk commented Apr 6, 2023

@l0rd it was enabled on dogfooding yesterday, and today during the verification on staging no performance pitfalls were spotted. We can disable it on production if some particular verification steps are required

@l0rd l0rd changed the title Limit the max number of workspace per user on Developer Sandbox Avoid startup failures on Developer Sandbox because of route counts quota Apr 7, 2023
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Apr 7, 2023

Issue looks fixed as expected, because I have checked 11 workspaces start > stop one by one on my Dev Sandbox production account, and have not experienced workspace failure because of too big number of routes.

There were zero routes shown in my OCP namespace at the end:

Screenshot from 2023-04-07 20-14-08

Screenshot from 2023-04-07 20-13-50

@dmytro-ndp dmytro-ndp added status/validated The issue resolution has been validated and removed status/validated The issue resolution has been validated labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hosted-che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. status/validated The issue resolution has been validated
Projects
None yet
Development

No branches or pull requests

4 participants