Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workspace storage docs to mention DWO's storage strategy attribute #22316

Open
AObuchow opened this issue Jun 22, 2023 · 6 comments
Open
Assignees
Labels
area/doc Issues related to documentation kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@AObuchow
Copy link

Is your enhancement related to a problem? Please describe

The Che documentation on requesting persistent workspace storage currently mentions mounting volumes and PVCs.

However, there is no mention of DWO's ability to automatically provision storage by creating a PVC, which can be configured on a per-workspace basis with the controller.devfile.io/storage-type attribute.

Describe the solution you'd like

The Che documentation should explain the usage of the controller.devfile.io/storage-type attribute.

Describe alternatives you've considered

We may not want to document this attribute, as it is "internal" (part of DWO's API, not Che) and Che already configures this attribute from the user dashboard.

Furthermore, users are most likely going to configure persistent storage for their workspaces using the Dashboard UI and not by modifying their devfile or devworkspace.

Additional context

No response

@AObuchow AObuchow added kind/enhancement A feature request - must adhere to the feature request template. area/doc Issues related to documentation labels Jun 22, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 22, 2023
@amisevsk amisevsk added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 23, 2023
@deerskindoll deerskindoll self-assigned this Sep 29, 2023
@che-bot
Copy link
Contributor

che-bot commented Mar 27, 2024

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 27, 2024
@deerskindoll
Copy link

/remove-lifecycle stale

@che-bot che-bot closed this as completed Apr 3, 2024
@deerskindoll deerskindoll reopened this Apr 3, 2024
@che-bot che-bot closed this as completed Apr 17, 2024
@AObuchow
Copy link
Author

/remove-lifecycle stale

@AObuchow AObuchow reopened this Apr 17, 2024
@che-bot che-bot closed this as completed Apr 24, 2024
@ibuziuk ibuziuk reopened this May 8, 2024
@ibuziuk
Copy link
Member

ibuziuk commented May 8, 2024

Reopening for clarification, is it really completed cc: @deerskindoll @AObuchow

@deerskindoll deerskindoll removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2024
@deerskindoll
Copy link

Reopening for clarification, is it really completed cc: @deerskindoll @AObuchow

not completed, I removed the lifecycle/stale label to prevent the bot from closing the issue again

@AObuchow
Copy link
Author

AObuchow commented May 9, 2024

@ibuziuk: @deerskindoll is correct, this has not been resolved. Though it's still debatable whether this is worth documenting:

We may not want to document this attribute, as it is "internal" (part of DWO's API, not Che) and Che already configures this attribute from the user dashboard.

Furthermore, users are most likely going to configure persistent storage for their workspaces using the Dashboard UI and not by modifying their devfile or devworkspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Issues related to documentation kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Development

No branches or pull requests

5 participants