Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log data when user access a workspace #5659

Closed
ghost opened this issue Jul 17, 2017 · 17 comments
Closed

Log data when user access a workspace #5659

ghost opened this issue Jul 17, 2017 · 17 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@ghost
Copy link

ghost commented Jul 17, 2017

From @tolusha on August 27, 2016 12:56

Write to log file each time when user access a workspace. Log file should be located near the tomcat access log.

Log data:

  • access timestamp in some universal format.
  • user name
  • workspace id
  • workspace name

Trigger:

  • User request a workspace by @get 'api/workspace` method

Copied from original issue: codenvy/codenvy#638

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @tolusha on August 28, 2016 7:10

@bmicklea @TylerJewell any requirements or we can postpone these issue?

@ghost ghost added kind/eclipse-che kind/enhancement A feature request - must adhere to the feature request template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Jul 17, 2017
@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @TylerJewell on August 28, 2016 12:7

Ok for me

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @tolusha on August 29, 2016 11:29

What kind of info to log

accessTime userId workspaceId permissions

What triggers should initiate logging

api/workspace/get method

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @TylerJewell on August 29, 2016 14:4

I think you are assuming that this is logging access through the Codenvy server. But I think that this would need to be any time that someone accesses the workspace directly. Since we do not proxy all user traffic through the Codenvy server, wouldn't this need to be something in the ws agent that logs the access back to the codenvy core?

The access would be any time someone does something that causes one of our agents to be accessed on the workspace. The agent would then log an agent access back with Codenvy for the user.

accessTime would be day / time in some universal format.
userid would be the username (pretty format) so tylerjewell@gmail.com if an email address
workspaceid would be the workspace id + workspace pretty name

Permissions would not be part of this logging. In the other issue where we display the permissions that a user has for each workspace they are a member of, then we would show their permission type there. This issue is specifically about when a user accesses a workspace.

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @tolusha on August 29, 2016 14:15

No Codenvy server. Ws master will log data once user requests a workspace.

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @TylerJewell on August 29, 2016 14:19

We need to assume that every access a user makes to any agent in a ws, will need to be logged as access in codenvy master.

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @tolusha on August 29, 2016 14:22

Do you mean ws-agent/terminal? anything else?

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @TylerJewell on August 29, 2016 14:25

Yes, fair question. I think ws-agent and terminal agent - those two make sense.

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @tolusha on August 29, 2016 14:38

Logging access to the terminal - an issue. Can't be solved quickly.

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @TylerJewell on August 29, 2016 14:39

Ok to defer that. Just handle ws-agent access initially.

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @tolusha on August 29, 2016 14:51

I've updated the description.

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @TylerJewell on July 5, 2017 13:48

@slemeur @bmicklea - do we think this is still useful in a k8s world?

@ghost
Copy link
Author

ghost commented Jul 17, 2017

From @bmicklea on July 10, 2017 16:51

up to @slemeur but I would assume the logging in k8s would be a decent start.

@slemeur
Copy link
Contributor

slemeur commented Jul 17, 2017

It depends what logs k8s are providing.

We will anyway need some sort of analytics and telemetry #5483. So I think this issue is still relevant.

@skabashnyuk
Copy link
Contributor

@slemeur @eivantsov are we talking about ws-agent logs?

@ghost
Copy link
Author

ghost commented Jan 17, 2018

hm... that's a very old issue that was moved from Coednvy repo and I don't think it makes sense for Che.

@bmicklea
Copy link

Closing as no longer relevant. We can open a new issue if this is a requirement going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Development

No branches or pull requests

3 participants