Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External builds integration #135

Open
dc740 opened this issue Sep 19, 2018 · 4 comments
Open

External builds integration #135

dc740 opened this issue Sep 19, 2018 · 4 comments

Comments

@dc740
Copy link

dc740 commented Sep 19, 2018

I'm trying to import Tock OS into eclipse, and I keep getting an error when I open a rust file.

LSP (org.eclipse.corrosion.RLS)
Error reading manifest path: Error message { msg: "could not find Cargo.toml in <my project path> or any parent directory"}

TockOS is an embedded operative system written in Rust. The project organization is a little odd: it is written with a Makefile at the top of the project. This Makefile actually handles calling cargo in the different parts of the operative system. Each chip or board has his own cargo project, and every time I try to open a rust file, I get the message listed above, because the cargo.toml file is not present at the root of the project.
I have to import Tock as "existing code as a Makefile project", since there isn't any main Cargo.toml file. It's only a Makefile, and the cargo files are inside the different parts of the project. The thing is: the different parts of the project do NOT compile independently unless you set some variables that are generated inside the Makefile

Is there any way to workaround this?

@mickaelistria
Copy link
Contributor

We're using https://github.com/rust-lang-nursery/rls/ that provides the language smartness. It seems like RLS strongly expects a Cargo.toml file. Please open an issue to RLS about it.

@dc740
Copy link
Author

dc740 commented Sep 19, 2018

Thank you. I filed the bug here:
rust-lang/rls#1057

@dc740 dc740 closed this as completed Sep 19, 2018
@dc740
Copy link
Author

dc740 commented Jan 5, 2019

Hi, while RLS does not have 100% compatibility there is an experimental feature that could be used to get the most important features working.
Is there a way to use the build_command feature in eclipse?

The details are here: rust-lang/rls#1057
and here: rust-lang/rls#988

While I understand this is not a priority I'm re-opening to keep track of the possible changes that could add support for other build systems to Corrosion. The RLS developer mentioned some progress on adding more build systems (other than the experimental build_command), so I'm hoping we can also keep track of the support in the eclipse plugin here.

thank you.

@mickaelistria
Copy link
Contributor

If you submit a PR to enable more features from RLS, it would be welcome.
PS: Please re-title the issue to something more specific and explicit.

@dc740 dc740 changed the title Corrosion in rust as subproject error External builds integration Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants