Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope commands #211

Closed
mbarbero opened this issue Mar 19, 2024 · 5 comments · Fixed by #215
Closed

Scope commands #211

mbarbero opened this issue Mar 19, 2024 · 5 comments · Fixed by #215

Comments

@mbarbero
Copy link
Contributor

Currently, the commands for Otterdog, such as verify, merge, etc., are not scoped. They can be placed anywhere within the comment body as long as they start with a /. This approach could potentially lead to confusion, unintended consequences, or even conflicts with other applications.

This ticket aims to discuss the adoption of scoped commands, similar to how Dependabot operates (https://docs.github.com/en/code-security/dependabot/working-with-dependabot/managing-pull-requests-for-dependency-updates#managing-dependabot-pull-requests-with-comment-commands), for example:

@otterdog verify
@otterdog merge
@otterdog help

Thoughts?

@netomi
Copy link
Contributor

netomi commented Mar 19, 2024

Sounds reasonable. I was already thinking of applying something similar as dependabot.

@netomi
Copy link
Contributor

netomi commented Mar 28, 2024

Using @otterdog is not a good idea, as it will tag the user otterdog, which exists:

https://github.com/otterdog

@netomi
Copy link
Contributor

netomi commented Mar 28, 2024

Some other prefixes that might work:

  • !
  • ?
  • .
  • /
  • # should not be used imho as it is used to reference Tickets / PRs

my preference would be ., so the commands would look like .otterdog validate, or just keep using / with scope, e.g. /otterdog validate

@mbarbero
Copy link
Contributor Author

mbarbero commented Mar 28, 2024

Good catch about @otterdog. I tend to prefer the / prefix (with scope, ie /otterdog) as it's closer to other "command language", like in IRC, Slack, or Discord.

@mbarbero
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants