From a0982ae31f934ae628af3a39c7a40dbed4191ad8 Mon Sep 17 00:00:00 2001
From: Marco Augusto <marcoaraujo96@gmail.com>
Date: Wed, 26 Jun 2024 13:37:19 +0100
Subject: [PATCH] CR carried out

---
 .../dataplane/spi/pipeline/StreamFailure.java |  7 +-
 .../spi/pipeline/StreamFailureTest.java       | 69 +++++++++++++++++++
 2 files changed, 70 insertions(+), 6 deletions(-)
 create mode 100644 spi/data-plane/data-plane-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java

diff --git a/spi/data-plane/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java b/spi/data-plane/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java
index ddbe79e24f0..e86a164379c 100644
--- a/spi/data-plane/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java
+++ b/spi/data-plane/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailure.java
@@ -9,7 +9,6 @@
  *
  *  Contributors:
  *       Bayerische Motoren Werke Aktiengesellschaft (BMW AG) - initial API and implementation
- *       zub4t - Improving failure detail message
  *
  */
 
@@ -33,11 +32,7 @@ public StreamFailure(List<String> messages, Reason reason) {
     @Override
     public String getFailureDetail() {
         var str = super.getFailureDetail();
-        if (str != null && !str.isEmpty()) {
-            str = reason + ": " + str;
-            return str;
-        }
-        return String.valueOf(reason);
+        return (str != null && !str.isEmpty()) ? (reason + ": " + str) : (reason + "");
     }
 
     public Reason getReason() {
diff --git a/spi/data-plane/data-plane-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java b/spi/data-plane/data-plane-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
new file mode 100644
index 00000000000..ffff19c17be
--- /dev/null
+++ b/spi/data-plane/data-plane-spi/src/test/java/org/eclipse/edc/connector/dataplane/spi/pipeline/StreamFailureTest.java
@@ -0,0 +1,69 @@
+/*
+ *  Copyright (c) 2024 Bayerische Motoren Werke Aktiengesellschaft (BMW AG)
+ *
+ *  This program and the accompanying materials are made available under the
+ *  terms of the Apache License, Version 2.0 which is available at
+ *  https://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  SPDX-License-Identifier: Apache-2.0
+ *
+ *  Contributors:
+ *       Bayerische Motoren Werke Aktiengesellschaft (BMW AG) - Initial implementation
+ *
+ */
+
+package org.eclipse.edc.connector.dataplane.spi.pipeline;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Stream;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.eclipse.edc.connector.dataplane.spi.pipeline.StreamFailure.Reason.GENERAL_ERROR;
+import static org.eclipse.edc.connector.dataplane.spi.pipeline.StreamFailure.Reason.NOT_AUTHORIZED;
+import static org.eclipse.edc.connector.dataplane.spi.pipeline.StreamFailure.Reason.NOT_FOUND;
+
+public class StreamFailureTest {
+    private StreamFailure streamFailure;
+    private String failureMessage;
+
+    @BeforeEach
+    void setup() {
+        failureMessage = "FAILURE MESSAGE";
+    }
+
+    @Test
+    void verify_with_failureDetail_message_startWith_notFound() {
+
+        streamFailure = new StreamFailure(List.of(failureMessage), NOT_FOUND);
+        assertThat(streamFailure.getFailureDetail()).startsWith(NOT_FOUND.toString());
+    }
+
+    @Test
+    void verify_with_failureDetail_message_startWith_notAuthorized() {
+
+        streamFailure = new StreamFailure(List.of(failureMessage), NOT_AUTHORIZED);
+        assertThat(streamFailure.getFailureDetail()).startsWith(NOT_AUTHORIZED.toString());
+    }
+
+    @Test
+    void verify_with_failureDetail_message_startWith_generalError() {
+
+        streamFailure = new StreamFailure(List.of(failureMessage), GENERAL_ERROR);
+        assertThat(streamFailure.getFailureDetail()).startsWith(GENERAL_ERROR.toString());
+    }
+
+    @Test
+    void verify_with_failureDetail_message_only_contains_reason_when_message_is_empty() {
+
+        assertThat(Stream.of(StreamFailure.Reason.values())
+                .allMatch(enumVal -> {
+                    return new StreamFailure(Collections.emptyList(), enumVal)
+                            .getFailureDetail()
+                            .equals(enumVal.toString());
+                })).isTrue();
+    }
+}