Update handlebars to fix a security issue #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found it in eclipse-ee4j#74, but had to wait for a fix: jknack/handlebars.java#703
Daniel-Dos
approved these changes
May 11, 2020
chkal
approved these changes
May 11, 2020
|
Is there already a CQ for this? |
|
Sorry for the delay - it took me a while to figure out if anything but dependencies changed in handlebars.java. It looks like a patch release with lots dependency bumping, but I filed the CQ anyway: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22204 |
|
CQ has been approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... we found in #74. There was nothing we could do back then, so we had to whitelist it.
Upstream fix: jknack/handlebars.java#703