Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec updates #315

Merged
merged 33 commits into from
Dec 21, 2019
Merged

Spec updates #315

merged 33 commits into from
Dec 21, 2019

Conversation

markt-asf
Copy link
Contributor

This is a work in progress. I still have some changes to make and I am expecting feedback on the changes I have already made. I'm providing this more so folks can provide feedback rather than expecting it to get merged (at this point anyway).

@markt-asf markt-asf force-pushed the spec-updates branch 2 times, most recently from 6eed59a to 2f69591 Compare November 27, 2019 14:42
@joakime
Copy link
Contributor

joakime commented Nov 27, 2019

How do the various WSC-6.5-2 and [WSC-6.5-2] entries work?
Are they self referencing within the same doc? (like html anchors)
Or are they referencing a document and/or process outside of this asciidoc?

Some lines may now be too long. That will be cleaned up in a later
commit.

Signed-off-by: Mark Thomas <markt@apache.org>
Line lengths and some cross-references still TODO

Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Bibliography still TODO

Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
@markt-asf
Copy link
Contributor Author

The WSC entries cross-reference to the TCK. There are references to them in the source eg:

   * @testName: constructortest
   * 
   * @assertion_ids: WebSocket:JAVADOC:8; WebSocket:JAVADOC:10;
   * WebSocket:JAVADOC:6; WebSocket:JAVADOC:7; WebSocket:JAVADOC:70;
   * WebSocket:JAVADOC:71; WebSocket:SPEC:WSC-3.2.1-1;
   * WebSocket:SPEC:WSC-3.2.2-1;
   * 
   * @test_Strategy: Test constructor
   */

The structure suggests there is some sort of tooling behind it but I don't know what or what that tooling does. I'll try and found out.

Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Exact date is TBD

Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Not as I expected but this gives correct output

Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
@markt-asf
Copy link
Contributor Author

I've completed my first pass and updated everything I could see needed updating. I'm going to proof read it again but I think the end result is now ready for review.

Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Signed-off-by: Mark Thomas <markt@apache.org>
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
I'm good with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants