Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties view for diagram editor #30

Closed
tortmayr opened this issue Nov 8, 2019 · 1 comment
Closed

Properties view for diagram editor #30

tortmayr opened this issue Nov 8, 2019 · 1 comment
Assignees

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Nov 8, 2019

We should make use of the SelectionService hook introduced in 1674493 which enables listening to model changes.

For now it's probably best to create a simple json-forms based property view with edit capabilities

see also eclipsesource/graphical-lsp#26

@tortmayr tortmayr transferred this issue from eclipse-glsp/glsp-theia-integration Feb 13, 2020
@planger planger added the nina label Apr 9, 2020
@planger
Copy link
Member

planger commented Jan 14, 2021

I think we can close this issue. Generic property view has been proposed to eclipse-theia/theia#8655 and JSONForms- and model-server-based will live in EMF.Cloud. So there is no need for this ticket here in GLSP anymore.

@planger planger closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants