Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (some) code relating to Java versions below 8 #1685

Open
stephan-herrmann opened this issue Sep 29, 2024 · 0 comments
Open

Remove (some) code relating to Java versions below 8 #1685

stephan-herrmann opened this issue Sep 29, 2024 · 0 comments

Comments

@stephan-herrmann
Copy link
Contributor

stephan-herrmann commented Sep 29, 2024

Since JDT/Core dropped support for Java versions below 8, the following queries in JavaModelUtil are now de-facto constants:

  • is1d8OrHigher() -> always true
  • is1d2OrHigher(), is1d4OrHigher(), is50OrHigher(), is1d7OrHigher() -> always false

I came here when checking if JDT/UI still "uses" org.eclipse.jdt.annotation_v1. In theory, the quickfix UnresolvedElementsBaseSubProcessor.addNullityAnnotationTypesProposals() would still try to locate this bundle in pre-Java8 projects, but since such projects are no longer supported, the version dependence in that method can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant