New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some diagnostic cause StackOverflowError when computing position #415

Closed

mickaelistria opened this issue May 24, 2024 · 0 comments · Fixed by #422

mickaelistria commented May 24, 2024

eg https://ci.eclipse.org/ls/job/jdt-core-incubator/job/dom-with-javac/129/testReport/junit/org.eclipse.jdt.core.tests.dom/ASTConverterStringTemplateTest/javac_specific_tests___test009/ , there are a few dozen of cases in the code.
In general, I'm not sure that the scanner based approach is good in general, it should only be used exceptionally.
cc @datho7561

datho7561 mentioned this issue

Don't use scanner tokens if the diagnostic length is non-zero #422

Merged

mickaelistria closed this as completed in #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment