Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable licensecheck #2966

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

akurtakov
Copy link
Contributor

No description provided.

@rgrunber
Copy link
Contributor

rgrunber commented Nov 17, 2023

All seem to pass but : 2/orbit/p2.eclipse.plugin/org.gradle.toolingapi/7.4.2.v20220712-0930-s, unknown, restricted, none .

It comes from https://www.eclipse.org/downloads/download.php?file=/buildship/updates/e423/snapshots/3.x/3.1.7.v20221108-1729-s/plugins/org.gradle.toolingapi_7.4.2.v20220712-0930-s.jar so it should be permitted.

@rgrunber
Copy link
Contributor

/request-license-review

@fbricon
Copy link
Contributor

fbricon commented Nov 20, 2023

/request-license-review

@rgrunber
Copy link
Contributor

@HannesWell
Copy link

/request-license-review

This can only work after the workflow has been submitted to the default branch of the repo.
Because only then this workflow is considered as listener to repository wide events like comment creation.

After this PE has been merged, you can still trigger a license review by adding that comment to this PR.

@rgrunber rgrunber added this to the End November 2023 milestone Nov 20, 2023
@rgrunber rgrunber merged commit 45aeb8d into eclipse-jdtls:master Nov 20, 2023
6 of 7 checks passed
@akurtakov
Copy link
Contributor Author

@rgrunber now we need /request-license-review from committer

@rgrunber
Copy link
Contributor

/request-license-review

@akurtakov
Copy link
Contributor Author

@HannesWell
Copy link

Indeed, but I can't tell why this happens. In general it works:

Maybe this repo has stricter permissions?
I can try to investigate it tomorrow evening.

@HannesWell
Copy link

I just added the required permissions explicitly to the license-check-workflow:

You probably have to specify the permissions similary in the caller workflow, if this repo does not by default grant all-write permisions, just like I did it for m2e:

akurtakov added a commit to akurtakov/eclipse.jdt.ls that referenced this pull request Nov 22, 2023
rgrunber pushed a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants