java.diagnostic.filter is broken on Windows #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why would you switch from the specific |
snjeza
changed the title
snjeza
changed the title
snjeza
changed the title
rgrunber
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
- Tested on Linux where I simply tried diagnostic filtering where a some source file had non-ascii characters and it seemed to work.
- Tested on Windows where I just expected the project to import when diagnostic filtering is enabled. I noticed filtering seems to work for both
/&\\.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3290
Without the PR, the
WorkspaceDiagnosticsHandlerTest.testDiagnosticFiltering()test fails on Windows.The fix has been based on #3290 (comment)
@Kamii0909 Thanks!