Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[US] Configure buildpacks image configuration through JKube's image configuration #2459

Closed
rohanKanojia opened this issue Nov 21, 2023 · 0 comments · Fixed by #2843
Closed
Assignees

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Nov 21, 2023

Component

JKube Kit

Task description

Part of #439

Related to #2457

As a user, I want to be able to provide a ImageConfiguration for the buildpack strategy, so that I can customize the generated container image.
These are the option to cover:

  • ImagePullPolicy
  • Tags
  • Environment variables
  • Volumes

Expected Behavior

As a user, If I specify imagePullPolicy, tags, environment variable via standard image configuration. I should be able to see them reflected in image created via Buildpacks

Acceptance Criteria

Given:

  • User is using buildpacks build strategy
  • User configures some aspect of image via XML/Groovy DSL configuration

When:

  • User performs k8s:build/k8sBuild

Then:

  • Aspects of image configured via image configuration (tags, environment variables) should be present in the final image generated by JKube using buildpacks build strategy.
@rohanKanojia rohanKanojia changed the title Automatically merge ImageConfiguration options with BuildPackConfiguration ImageConfiguration options should be able to affect pack CLI behavior Nov 28, 2023
@sunix sunix changed the title ImageConfiguration options should be able to affect pack CLI behavior [US] ImageConfiguration options should be able to affect pack CLI behavior Dec 4, 2023
@sunix sunix changed the title [US] ImageConfiguration options should be able to affect pack CLI behavior [US] Configure buildpacks image configuration through JKube's image configuration Dec 4, 2023
@rohanKanojia rohanKanojia self-assigned this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant