ArchiveDecompressor : Repalce raw use of parameterized class 'ArchiveInputStream' by providing type

[rohanKanojia]

Component

JKube Kit

Task description

Description

ArchiveInputStream is a parameterized class, however we don't seem to be providing it's type while creating it here:

https://github.com/eclipse/jkube/blob/b10c54f17d33974c80c1fc4a26ce6a44ef29dcf7/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/archive/ArchiveDecompressor.java#L91

We should specify complete type parameter like this:

try (ArchiveInputStream<ArchiveEntry> ais = new ArchiveStreamFactory().createArchiveInputStream(is)) {

Expected Behavior

Parameterized type is provided in Generic

Acceptance Criteria

• Raw use is replaced by providing generic type in variable declaration
• ArchiveDecompressorTest passes after making this change

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

• Minikube get started guide
• Kind (Requires Docker) quick start

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

[Jonathanlemon]

Hi @rohanKanojia I'd like to tackle this. For the parameterized type, shall I use ArchiveEntry, or should I find a different suitable type?

[manusa]

shall I use ArchiveEntry

Yes, the relevant code changes are explained in the description. The point of this issue is for you to get familiarized with the Eclipse contribution procedure (ECA, creating a fork, pull request, and so on).