We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes Maven Plugin
ResourceMojo seems to be overriding this method from it's parent class: https://github.com/eclipse/jkube/blob/335aa3bcd76523c4f9ee89dab46225278b3ce20d/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ResourceMojo.java#L182-L185
However, if you see the original method in super class, it's exactly the same: https://github.com/eclipse/jkube/blob/335aa3bcd76523c4f9ee89dab46225278b3ce20d/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/AbstractJKubeMojo.java#L188-L190
There is no need to add @Override method if overridden implementation isn't doing anything different.
@Override
Remove redundant method from ResourceMojo that's already defined in AbstractJKubeMojo
getRuntimeMode()
mvn clean install
The text was updated successfully, but these errors were encountered:
hai, I would like to work on this. May I?
Sorry, something went wrong.
Can i work on this?
professorabhay
Successfully merging a pull request may close this issue.
Component
Kubernetes Maven Plugin
Task description
Description
ResourceMojo seems to be overriding this method from it's parent class:
https://github.com/eclipse/jkube/blob/335aa3bcd76523c4f9ee89dab46225278b3ce20d/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ResourceMojo.java#L182-L185
However, if you see the original method in super class, it's exactly the same:
https://github.com/eclipse/jkube/blob/335aa3bcd76523c4f9ee89dab46225278b3ce20d/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/AbstractJKubeMojo.java#L188-L190
There is no need to add
@Override
method if overridden implementation isn't doing anything different.Expected Behavior
Remove redundant method from ResourceMojo that's already defined in AbstractJKubeMojo
Acceptance Criteria
getRuntimeMode()
is removed from ResourceMojomvn clean install
The text was updated successfully, but these errors were encountered: