Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenshiftWatchMojo Remove unused imports #2967

Closed
1 task done
manusa opened this issue Apr 24, 2024 · 2 comments · Fixed by #2983
Closed
1 task done

OpenshiftWatchMojo Remove unused imports #2967

manusa opened this issue Apr 24, 2024 · 2 comments · Fixed by #2983
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone

Comments

@manusa
Copy link
Member

manusa commented Apr 24, 2024

Description

The class OpenshiftWatchMojo has unused imports.

The following lines:

import org.apache.maven.artifact.DependencyResolutionRequiredException;

  • should be removed

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Apr 24, 2024
@MukarramHaq
Copy link
Contributor

Hello, I would like to work on this. Can you assign this to me?

@rohanKanojia rohanKanojia mentioned this issue Apr 29, 2024
17 tasks
@manusa manusa added this to the 1.17.0 milestone Apr 29, 2024 — with automated-tasks
@MukarramHaq
Copy link
Contributor

Thank you for this opportunity. I learned a lot about open source contributing and surprisingly learned a lot about git and github as well, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants