Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageChangeTriggerEnricher 'containerToImageMap.size() != 0' can be replaced with '!containerToImageMap.isEmpty()' #3203

Closed
manusa opened this issue Jun 26, 2024 · 5 comments · Fixed by #3252
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone

Comments

@manusa
Copy link
Member

manusa commented Jun 26, 2024

Description

The call to Map.size can be replaced with isEmpty in ImageChangeTriggerEnricher.

The following line:

should be changed to:

                if (!containerToImageMap.isEmpty()) {

🔴 Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Jun 26, 2024
@YAKSH22WEBSITEHACKERS
Copy link

YAKSH22WEBSITEHACKERS commented Jun 26, 2024

Hi @manusa
KINDLY ASSIGN THIS TO ME.....

@OrneyVortex
Copy link

Hello @manusa can you assign this to me if not resolved yet?
I can give it a try

@manusa
Copy link
Member Author

manusa commented Jul 3, 2024

Hi @OrneyVortex, let's ask the current assignee first. We usually give 1-2 weeks margin to complete the issue. Note that there are still plenty open and unassigned first-timers-only issues first-timers-only Is this your first time contributing? This could be a good place to start! (especially at the bottom of the list).
Hi @YAKSH22WEBSITEHACKERS, are you working on this?

@vijaybhagwat24
Copy link
Contributor

may i pick this up?

@rohanKanojia
Copy link
Member

rohanKanojia commented Jul 22, 2024

@YAKSH22WEBSITEHACKERS : Unassigning you from the issue as there hasn't been any update since past 1 month

@vijaybhagwat24 vijaybhagwat24 mentioned this issue Jul 22, 2024
9 tasks
@manusa manusa added this to the 1.17.0 milestone Jul 22, 2024 — with automated-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants