Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When associating a DTD through <?xml-model...?>, DTD-related errors should be aggregated #918

Closed
datho7561 opened this issue Oct 22, 2020 · 1 comment
Labels
bug Something isn't working validation
Milestone

Comments

@datho7561
Copy link
Contributor

Please refer to issue #768 and this comment on the PR that addresses it.

When a DTD is associated with a file through <?xml-model...?>, and errors exist on the associated DTD, an error message should be shown. The current behaviour is that a "file not found" error is given:
ReferencesBorkedDTDXMLModel

This error should instead indicate that the DTD is invalid. Ideally, this error should also be an aggregation of the DTD errors like in #768.

Quick example to reproduce this issue:

ReferencesBorked.xml:

<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="Borked.dtd" type="application/xml-dtd"?>
<root>
</root>

Borked.dtd:

<!ELEMENT root (branch+)>
<!ELEMENTbranch (#PCDATA)>
@angelozerr
Copy link
Contributor

Fixed with #916

@angelozerr angelozerr added this to the 0.14.0 milestone Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation
Projects
None yet
Development

No branches or pull requests

2 participants