Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Environment: Vagrant File #1161

Open
bitvijays opened this issue Nov 24, 2021 · 9 comments
Open

Dev Environment: Vagrant File #1161

bitvijays opened this issue Nov 24, 2021 · 9 comments
Labels
discussion Discussion about anything

Comments

@bitvijays
Copy link

Dear Leshan Team,

Hope you are doing well. I was just wondering, would leshan team would be interested in providing a Vagrant file for development purposes? We are trying some development with Leshan, so have created one and are happy to share. Have attached for your reference. Would be happy to modify as per requirement and submit a PR.
Vagrantfile_Leshan.txt

@sbernard31
Copy link
Contributor

Thx for sharing this. 🙏

This reminds me another old discussion about providing this kind of file : #414

To be honest, I still not so sure of the benefits of this.
I feel there is enough official easy way to access to the demo, like :

So I'm not sure we want to multiply this kind of file in the repository and maintain it. 🤔

But, If wanted I can add link to this kind of file in the documentation. Maybe in the F.A.Q ?
This could be a simple link to an issue like this one or a link to a code repository which maintains it.

@sbernard31 sbernard31 added the discussion Discussion about anything label Nov 26, 2021
@bitvijays
Copy link
Author

bitvijays commented Dec 1, 2021

Dear @sbernard31 , Hope you are doing well and having a good week.

This is a bit different from the snapcraft. The snapcraft was mainly to run the demo that can easily by done by the steps provided.

The vagrant file is mainly for doing the Leshan development. For instance, we try to engage students to some Leshan development as mentioned in #974 .

For instance, we ask the student to just vagrant up, and then configure Visual Studio code and use the Java Development Extension to do the code development.

I would be happy to create a Readme.md file and provide instructions on how to use and configure the system for development. Happy to maintain :) Maybe, we can add such details in Leshan Wiki at https://github.com/eclipse/leshan/blob/master/README.md

Kind Regards,
Vijay

@sbernard31
Copy link
Contributor

For instance, we try to engage students to some Leshan development as mentioned in #974 .

Good to hear that 🙂.

The vagrant file is mainly for doing the Leshan development.

I better understand your use case now.

But just to be sure the benefits for a developer is that he will just need to install vagrant + virtualbox instead of installing a JDK+ yarn ?

In your case, I can guess some benefits as this allow every students to use same development environment but I'm not sure if this is something which should be provided by leshan project itself.

At Leshan project point of view, one drawback could be that every developers use the same environment and so Leshan will be tested on only 1 platform.

So I'm still not so sure 🤔

If we decide to not put it in Leshan repository, would you like to create a dedicated repo with that file that you maintain (with the documentation to use it) and we refer to it leshan documentation wiki ?

I looked at your vagrant file :

@Michal-Wadowski do you have any opinion on this ?

@Michal-Wadowski
Copy link
Contributor

Unfortunately I have no experience with Vagrant so my opinion is based only on what I read about it.

I think every method that ease development should be considered. Maybe we could create a subpage in readme witch explain different approaches to development (with Eclipse, IntelliJ, Valgrand)?

I don't know if it's Vagrant domain, but it would be good to make way to test project on different environments (linux/windows etc.) to avoid problems like #1147

@bitvijays
Copy link
Author

@sbernard31 Thank you for your support. I would suggest, maybe we can create a wiki page that would also contain the contents of vagrant file.. which people can copy. I would be happy to write the introduction and then we can refer it from https://github.com/eclipse/leshan/blob/master/README.md.

@sbernard31
Copy link
Contributor

@bitvijays could you clarify something for me 🙏

Is the vagrant file for Leshan Contributor/Committer (I mean someone who want to propose PR for Leshan) ?
OR
For Leshan user as a base to start to code your own project based on Leshan library ?

@bitvijays
Copy link
Author

Hi @sbernard31 ,

The first one Is the vagrant file for Leshan Contributor/Committer (I mean someone who want to propose PR for Leshan) ? -- Yes

@sbernard31
Copy link
Contributor

OK, so I propose to write a wiki page.
Then add a link to this page at https://github.com/eclipse/leshan/wiki/How-to-contribute

Does it sounds good ?

@bitvijays
Copy link
Author

Perfectly fine! I will get it done soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion about anything
Projects
None yet
Development

No branches or pull requests

3 participants