diff --git a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/InjectionFilter.java b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/InjectionFilter.java index cecddc83e..fbb1e2e81 100644 --- a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/InjectionFilter.java +++ b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/InjectionFilter.java @@ -37,11 +37,11 @@ public class InjectionFilter implements IFilter { private static final String disabledBook3 = "\n"; //$NON-NLS-1$ - private final String TOPIC_CSS = "topic_css"; //$NON-NLS-1$ - private final String NAV_CSS = "nav_css"; //$NON-NLS-1$ - private final String NARROW_CSS = "narrow_css"; //$NON-NLS-1$ - private final String DISABLED_CSS = "disabled_css"; //$NON-NLS-1$ - private final String REMOTE_CSS = "remote_css"; //$NON-NLS-1$ + private static final String TOPIC_CSS = "topic_css"; //$NON-NLS-1$ + private static final String NAV_CSS = "nav_css"; //$NON-NLS-1$ + private static final String NARROW_CSS = "narrow_css"; //$NON-NLS-1$ + private static final String DISABLED_CSS = "disabled_css"; //$NON-NLS-1$ + private static final String REMOTE_CSS = "remote_css"; //$NON-NLS-1$ private boolean isRemote; public InjectionFilter( boolean isRemote ) { diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextMergeTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextMergeTest.java index fff3efc06..84e7aeeb5 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextMergeTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextMergeTest.java @@ -35,10 +35,10 @@ public class ContextMergeTest { private static final String TOPIC_HEAD_ECLIPSE = ""; private static final String CONTEXT_DESCRIPTION = "Context Description"; private static final String CONTEXT_HEAD = ""; - private final String TOPIC_ECLIPSE = ""; - private final String TOPIC_BUGZILLA = ""; + private static final String TOPIC_ECLIPSE = ""; + private static final String TOPIC_BUGZILLA = ""; private final String TOPIC_WITH_ENABLEMENT = TOPIC_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + TOPIC_END; - private final String END_CONTEXT = ""; + private static final String END_CONTEXT = ""; private Context createContext(final String contextSource) { Context context; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextTest.java index 4e75ed120..d04fe15a2 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextTest.java @@ -44,17 +44,17 @@ public class ContextTest { private static final String FILTER_OUT = ""; private static final String TOPIC_END = ""; private static final String TOPIC_HEAD_ECLIPSE = ""; - private final String TOPIC_OLD_FILTER_DISABLED = ""; private static final String CONTEXT_DESCRIPTION = "Context Description"; private static final String EMPTY_DESCRIPTION = ""; private static final String CONTEXT_HEAD = ""; private static final String CONTEXT_HEAD_WITH_ATTRIBUTE = ""; - private final String TOPIC_ECLIPSE = ""; - private final String TOPIC_WITH_ENABLEMENT = TOPIC_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + TOPIC_END; - private final String TOPIC_DISABLED = TOPIC_HEAD_ECLIPSE + ENABLEMENT_INVALID + TOPIC_END; - private final String TOPIC_FILTER_OUT = TOPIC_HEAD_ECLIPSE + FILTER_OUT + TOPIC_END; - private final String END_CONTEXT = ""; + private static final String TOPIC_ECLIPSE = ""; + private static final String TOPIC_WITH_ENABLEMENT = TOPIC_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + TOPIC_END; + private static final String TOPIC_DISABLED = TOPIC_HEAD_ECLIPSE + ENABLEMENT_INVALID + TOPIC_END; + private static final String TOPIC_FILTER_OUT = TOPIC_HEAD_ECLIPSE + FILTER_OUT + TOPIC_END; + private static final String END_CONTEXT = ""; @Before public void setUp() throws Exception { diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/IndexEntryTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/IndexEntryTest.java index e5a9a7836..7973ae168 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/IndexEntryTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/IndexEntryTest.java @@ -51,23 +51,23 @@ public class IndexEntryTest { private static final String NEGATED_FILTER_OUT = ""; private static final String ENTRY_END = ""; private static final String ENTRY_HEAD_ECLIPSE = ""; - private final String ENTRY_ECLIPSE = ""; - private final String ENTRY_BUGZILLA = ""; - private final String TOPIC_BUGZILLA = ""; - private final String SEE_ALSO_SDK = ""; + private static final String ENTRY_ECLIPSE = ""; + private static final String ENTRY_BUGZILLA = ""; + private static final String TOPIC_BUGZILLA = ""; + private static final String SEE_ALSO_SDK = ""; private final String ENTRY_WITH_ENABLEMENT = ENTRY_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + ENTRY_END; private final String ENTRY_NOT_ENABLED = ENTRY_HEAD_ECLIPSE + ENABLEMENT_INVALID + ENTRY_END; private final String ENTRY_FILTER_IN = ENTRY_HEAD_ECLIPSE + FILTER_IN + ENTRY_END; private final String ENTRY_FILTER_OUT = ENTRY_HEAD_ECLIPSE + FILTER_OUT + ENTRY_END; private final String ENTRY_FILTER_MIXED = ENTRY_HEAD_ECLIPSE + FILTER_IN + FILTER_OUT + ENTRY_END; - private final String ENTRY_OLD_FILTER = ""; - private final String ENTRY_OLD_FILTER_DISABLED = ""; - private final String ENTRY_OLD_FILTER_IN__NEGATED = ""; - private final String ENTRY_OLD_FILTER_OUT_NEGATED = ""; private final String ENTRY_WITH_CHILD = ENTRY_HEAD_ECLIPSE + ENTRY_BUGZILLA + ENTRY_END; private final String ENTRY_WITH_TOPIC = ENTRY_HEAD_ECLIPSE + TOPIC_BUGZILLA + ENTRY_END; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/TopicTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/TopicTest.java index d9def5aea..51fcc8d59 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/TopicTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/TopicTest.java @@ -48,21 +48,21 @@ public class TopicTest { private static final String NEGATED_FILTER_OUT = ""; private static final String TOPIC_END = ""; private static final String TOPIC_HEAD_ECLIPSE = ""; - private final String TOPIC_ECLIPSE = ""; - private final String TOPIC_BUGZILLA = ""; + private static final String TOPIC_ECLIPSE = ""; + private static final String TOPIC_BUGZILLA = ""; private final String TOPIC_WITH_ENABLEMENT = TOPIC_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + TOPIC_END; private final String TOPIC_NOT_ENABLED = TOPIC_HEAD_ECLIPSE + ENABLEMENT_INVALID + TOPIC_END; private final String TOPIC_FILTER_IN = TOPIC_HEAD_ECLIPSE + FILTER_IN + TOPIC_END; private final String TOPIC_FILTER_OUT = TOPIC_HEAD_ECLIPSE + FILTER_OUT + TOPIC_END; private final String TOPIC_FILTER_MIXED = TOPIC_HEAD_ECLIPSE + FILTER_IN + FILTER_OUT + TOPIC_END; - private final String TOPIC_OLD_FILTER = ""; - private final String TOPIC_OLD_FILTER_DISABLED = ""; - private final String TOPIC_OLD_FILTER_IN__NEGATED = ""; - private final String TOPIC_OLD_FILTER_OUT_NEGATED = ""; private final String TOPIC_WITH_CHILD = TOPIC_HEAD_ECLIPSE + TOPIC_BUGZILLA + TOPIC_END; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/XHTMLEntityTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/XHTMLEntityTest.java index 571302388..692ae0dba 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/XHTMLEntityTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/XHTMLEntityTest.java @@ -29,11 +29,11 @@ import org.w3c.dom.Node; public class XHTMLEntityTest { - private final String XHTML1 = "\n" + + private static final String XHTML1 = "\n" + "\n" + "\n" + ""; - private final String XHTML2 = ""; + private static final String XHTML2 = ""; public void checkResolution(String text, int expected) throws Exception { DocumentBuilder documentBuilder; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/FilterTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/FilterTest.java index 42aa1e9d3..d697128a4 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/FilterTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/FilterTest.java @@ -33,23 +33,23 @@ */ public class FilterTest { - private final String HTML40 = ""; - private final String HEAD1 = ""; - private final String HEAD2 = ""; - private final String HEADLC1 = ""; - private final String HEADLC2 = ""; - private final String CONTENT_TYPE_ISO_8859_1 = ""; - private final String CONTENT_TYPE_ISO_8859_1_UC = ""; - private final String CONTENT_TYPE_UTF8 = ""; - private final String CONTENT_TYPE_UTF8UC = ""; - private final String BODY1 = ""; - private final String BODY2 = ""; - private final String BODYLC1 = ""; - private final String BODYLC2 = ""; - private final String CSS1 = ""; - private final String CSS2 = ""; - private final String CONTENT1 = "

Content1

"; - private final String CONTENT2 = "

Content2

"; + private static final String HTML40 = ""; + private static final String HEAD1 = ""; + private static final String HEAD2 = ""; + private static final String HEADLC1 = ""; + private static final String HEADLC2 = ""; + private static final String CONTENT_TYPE_ISO_8859_1 = ""; + private static final String CONTENT_TYPE_ISO_8859_1_UC = ""; + private static final String CONTENT_TYPE_UTF8 = ""; + private static final String CONTENT_TYPE_UTF8UC = ""; + private static final String BODY1 = ""; + private static final String BODY2 = ""; + private static final String BODYLC1 = ""; + private static final String BODYLC2 = ""; + private static final String CSS1 = ""; + private static final String CSS2 = ""; + private static final String CONTENT1 = "

Content1

"; + private static final String CONTENT2 = "

Content2

"; private String CHINESE_CONTENT = "

" + (char)24320 + (char)21457 + (char)29932 + "

"; private String CHINESE_ENTITY_CONTENT = "

开发瓬

"; diff --git a/org.eclipse.ui.cheatsheets/src/org/eclipse/ui/internal/cheatsheets/registry/CheatSheetRegistryReader.java b/org.eclipse.ui.cheatsheets/src/org/eclipse/ui/internal/cheatsheets/registry/CheatSheetRegistryReader.java index bf74beec2..cbf1ecf11 100644 --- a/org.eclipse.ui.cheatsheets/src/org/eclipse/ui/internal/cheatsheets/registry/CheatSheetRegistryReader.java +++ b/org.eclipse.ui.cheatsheets/src/org/eclipse/ui/internal/cheatsheets/registry/CheatSheetRegistryReader.java @@ -177,7 +177,7 @@ public static CheatSheetRegistryReader getInstance() { protected CheatSheetCollectionElement cheatsheets; private ArrayList deferCategories = null; private ArrayList deferCheatSheets = null; - private final String csItemExtension = "cheatSheetItemExtension"; //$NON-NLS-1$ + private static final String csItemExtension = "cheatSheetItemExtension"; //$NON-NLS-1$ protected Map taskExplorers = new HashMap<>(); protected Map taskEditors = new HashMap<>(); private Map nestedCategoryIds = new HashMap<>(); diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/EclipseRSSViewer.java b/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/EclipseRSSViewer.java index 14a15e5d3..4ef58fb3e 100644 --- a/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/EclipseRSSViewer.java +++ b/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/EclipseRSSViewer.java @@ -92,7 +92,7 @@ public class EclipseRSSViewer implements IIntroContentProvider { - private final int SOCKET_TIMEOUT = 6000; //milliseconds + private static final int SOCKET_TIMEOUT = 6000; //milliseconds private static final String INTRO_SHOW_IN_BROWSER = "http://org.eclipse.ui.intro/openBrowser?url="; //$NON-NLS-1$