From e8e9389f3ab20df3e210f6df4086c2198393b47f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Kubitz?= Date: Tue, 13 Jun 2023 14:45:32 +0200 Subject: [PATCH] HelpData: close stream after use normally parse() will close stream but won't do it on exception. --- org.eclipse.help/src/org/eclipse/help/internal/HelpData.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/org.eclipse.help/src/org/eclipse/help/internal/HelpData.java b/org.eclipse.help/src/org/eclipse/help/internal/HelpData.java index 52f087df0..b3d1c86a1 100644 --- a/org.eclipse.help/src/org/eclipse/help/internal/HelpData.java +++ b/org.eclipse.help/src/org/eclipse/help/internal/HelpData.java @@ -173,9 +173,8 @@ private void loadHelpData() { hiddenIndexes = new HashSet<>(); sortMode = "true"; //$NON-NLS-1$ if (url != null) { - try { + try (InputStream in = url.openStream()) { SAXParser parser = SAXParserFactory.newInstance().newSAXParser(); - InputStream in = url.openStream(); parser.parse(in, new Handler()); } catch (Throwable t) {