Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer use PHP for "New & Noteworthy" #122

Open
BeckerWdf opened this issue Feb 14, 2024 · 10 comments
Open

No longer use PHP for "New & Noteworthy" #122

BeckerWdf opened this issue Feb 14, 2024 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@BeckerWdf
Copy link
Contributor

Eclipse Foundation proposes to retire PHP. See: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1934 and
the following mail on the eclipse.org-committers mailing list:

Greetings folks,

If your Eclipse project is using PHP for its website on https://eclipse.dev/ or for downloads, please be aware that we are proposing its deprecation.

It may have made sense to allow PHP project content on our servers in the past, but in today's context, it does not. Most projects now support a static website built by a CI mechanism. The same also applies to download pages, where PHP was typically used to read the content of the filesystem in real time, this can be done at build/promotion time.

Please see https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1934 for the details. The short:

  • We are proposing to remove PHP capabilities for project content on https://eclipse.dev/ by Dec 31, 2024.

  • We are proposing to remove PHP capabilities for project content on DOWNLOADS and ARCHIVES by Dec 31, 2025.

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Eclipse-Service/Infrastructure-changes-Guide

Do note that, in today's security context, removing PHP is unavoidable. We realize that the EF has many items in a deprecation state - either in progress, or as is the case here, proposed and in planning. This is the unfortunate consequence of maintaining an infrastructure that has not properly evolved as the environment around us has changed, and even in yesteryear's security context, are no longer fit or are simply unacceptable.

Thank you for reading. Please comment on Issue 1934 (link above).

The New & Noteworthy document uses some PHP. E.g. see: https://eclipse.dev/eclipse/news/4.31/platform.php

I even don't know what these PHP scripts do. Can't we simply produce static HTML files instead?

@BeckerWdf BeckerWdf added bug Something isn't working help wanted Extra attention is needed and removed bug Something isn't working labels Feb 14, 2024
@vogella
Copy link
Contributor

vogella commented Feb 14, 2024

The PMC decided a while ago that we should migrate the PHP / HTML page to markdown (or Asccidoc) so make it easier to maintain. Similar to the UX guidelines we could generate HTML from them. So far nobody had time to do this conversion. I would be IMHO much easier to maintain than writing HTML code.

@jukzi
Copy link
Contributor

jukzi commented Feb 14, 2024

I guess everybody would be willing to write new stuff in markdown. The main question to me is if the old N&Ns need to be converted - which probably does not make fun.
For me it would be fine if old N&N would still be in the repository but not populated to the webpage anymore.

@merks
Copy link
Contributor

merks commented Feb 14, 2024

It’s mostly already html with a little bit of php wrapper. Perhaps some JavaScript magic could be used instead to render it.

@BeckerWdf
Copy link
Contributor Author

It’s mostly already html with a little bit of php wrapper. Perhaps some JavaScript magic could be used instead to render it.

Can you explain what this wrapper does and why it's needed?

@mickaelistria
Copy link
Contributor

For me it would be fine if old N&N would still be in the repository but not populated to the webpage anymore.

Yes, it's OK to not bother too much about older N&N stuff and not worth wasting effort in a conversion to markdown.
Also, I believe that the links to plain html page would still work even if PHP is retired, eg https://eclipse.dev/eclipse/news/4.12/platform.html doesn't use PHP. So as there is no strong payload in PHP files, when EF retires PHP, we can either ignore it, or just remove all php files from the N&N repo and site.

@merks
Copy link
Contributor

merks commented Feb 16, 2024

@BeckerWdf

Just compare this page

https://eclipse.dev/eclipse/news/4.31/platform.html

to this page:

https://eclipse.dev/eclipse/news/4.31/platform.php

which just does this wrapping to create the common theming/scaffolding:

image

There must be another way to do that without statically copying the entire scaffolding. We might ask the Foundation experts about that...

@BeckerWdf
Copy link
Contributor Author

There must be another way to do that without statically copying the entire scaffolding. We might ask the Foundation experts about that...

I agree that this must be possible. Should I ask in the linked gitlab-ticket?

@merks
Copy link
Contributor

merks commented Feb 16, 2024

I agree that this must be possible. Should I ask in the linked gitlab-ticket?

Yes, let's ask there. It's of course in the Foundation's best interest too that we are able to present a common, modern, look-and-feel...

@BeckerWdf
Copy link
Contributor Author

I agree that this must be possible. Should I ask in the linked gitlab-ticket?

Yes, let's ask there. It's of course in the Foundation's best interest too that we are able to present a common, modern, look-and-feel...

I asked there: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1934#note_1754553

@BeckerWdf
Copy link
Contributor Author

The Acknowledgement page also uses PHP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants