[CI] Intermittent failure related to native dependencies

[marcdumais-work]

Description
CI seems to fail often, probably related to the nsfw problem reported in the main Theia repo. I do not see this problem when building locally.

There's already a new version of nsfw out that fixes this, that matches the version range we seek, that should be pulled and used (no yarn.lock in this repo).

For now I have cleared the Travis cache in case it might help. The build then passed twice in a row. Maybe fixed? Let's keep the issue around for a little while to confirm

Update: now looks more like an intermittent problem when we're building native npm packages.

[marcdumais-work]

Initially when I registered this issue I noticed it was was nsfw failing. But now it looks more like a general flakiness with any/all native npm dependencies, since I see sometimes it's node-pty that fails, other times it's drivelist: https://travis-ci.com/github/eclipse-theia/theia-cpp-extensions/jobs/319306042#L398-L619

[5/5] Building fresh packages...
398error /home/travis/build/eclipse-theia/theia-cpp-extensions/node_modules/drivelist: Command failed.
399Exit code: 1
400Command: prebuild-install || node-gyp rebuild
401Arguments: 
402Directory: /home/travis/build/eclipse-theia/theia-cpp-extensions/node_modules/drivelist
403Output:
404prebuild-install WARN install No prebuilt binaries found (target=10.20.1 runtime=node arch=x64 platform=linux)
405gyp info it worked if it ends with ok
406gyp info using node-gyp@6.1.0
407gyp info using node@10.20.1 | linux | x64
408gyp info find Python using Python version 3.5.2 found at "/usr/bin/python3"
409gyp info spawn /usr/bin/python3
410gyp info spawn args [ '/home/travis/build/eclipse-theia/theia-cpp-extensions/node_modules/electron-rebuild/node_modules/node-gyp/gyp/gyp_main.py',
411gyp info spawn args   'binding.gyp',
412gyp info spawn args   '-f',
413gyp info spawn args   'make',
414gyp info spawn args   '-I',
415gyp info spawn args   '/home/travis/build/eclipse-theia/theia-cpp-extensions/node_modules/drivelist/build/config.gypi',
416gyp info spawn args   '-I',
417gyp info spawn args   '/home/travis/build/eclipse-theia/theia-cpp-extensions/node_modules/electron-rebuild/node_modules/node-gyp/addon.gypi',
418gyp info spawn args   '-I',
419gyp info spawn args   '/home/travis/.cache/node-gyp/10.20.1/include/node/common.gypi',
420gyp info spawn args   '-Dlibrary=shared_library',
421gyp info spawn args   '-Dvisibility=default',
422gyp info spawn args   '-Dnode_root_dir=/home/travis/.cache/node-gyp/10.20.1',
423gyp info spawn args   '-Dnode_gyp_dir=/home/travis/build/eclipse-theia/theia-cpp-extensions/node_modules/electron-rebuild/node_modules/node-gyp',
424gyp info spawn args   '-Dnode_lib_file=/home/travis/.cache/node-gyp/10.20.1/<(target_arch)/node.lib',
535gyp info spawn args   '-Dmodule_root_dir=/home/travis/build/eclipse-theia/theia-cpp-extensions/node_modules/drivelist',
536gyp info spawn args   '-Dnode_engine=v8',
537gyp info spawn args   '--depth=.',
538gyp info spawn args   '--no-parallel',
539gyp info spawn args   '--generator-output',
540gyp info spawn args   'build',
541gyp info spawn args   '-Goutput_dir=.' ]
542gyp info spawn make
543gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
544make: Entering directory '/home/travis/build/eclipse-theia/theia-cpp-extensions/node_modules/drivelist/build'
545  CXX(target) Release/obj.target/drivelist/src/drivelist.o
546In file included from ../../nan/nan.h:284:0,
547                 from ../src/drivelist.cpp:17:
548../../nan/nan_maybe_pre_43_inl.h: In function ‘Nan::MaybeLocal<v8::String> Nan::ToDetailString(v8::Handle<v8::Value>)’:
549../../nan/nan_maybe_pre_43_inl.h:53:53: error: no matching function for call to ‘v8::Value::ToDetailString()’
550   return MaybeLocal<v8::String>(val->ToDetailString());
551                                                     ^
552../../nan/nan_maybe_pre_43_inl.h:53:53: note: candidate is:
553In file included from /home/travis/.cache/node-gyp/10.20.1/include/node/node.h:63:0,
554                 from ../../nan/nan.h:54,
555                 from ../src/drivelist.cpp:17:
556/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:2429:44: note: v8::MaybeLocal<v8::String> v8::Value::ToDetailString(v8::Local<v8::Context>) const
557   V8_WARN_UNUSED_RESULT MaybeLocal<String> ToDetailString(
558                                            ^
559/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:2429:44: note:   candidate expects 1 argument, 0 provided
560In file included from ../../nan/nan.h:284:0,
561                 from ../src/drivelist.cpp:17:
562../../nan/nan_maybe_pre_43_inl.h: In function ‘Nan::MaybeLocal<v8::Uint32> Nan::ToArrayIndex(v8::Handle<v8::Value>)’:
563../../nan/nan_maybe_pre_43_inl.h:58:51: error: no matching function for call to ‘v8::Value::ToArrayIndex()’
564   return MaybeLocal<v8::Uint32>(val->ToArrayIndex());
565                                                   ^
566../../nan/nan_maybe_pre_43_inl.h:58:51: note: candidate is:
567In file included from /home/travis/.cache/node-gyp/10.20.1/include/node/node.h:63:0,
568                 from ../../nan/nan.h:54,
569                 from ../src/drivelist.cpp:17:
570/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:2463:44: note: v8::MaybeLocal<v8::Uint32> v8::Value::ToArrayIndex(v8::Local<v8::Context>) const
571   V8_WARN_UNUSED_RESULT MaybeLocal<Uint32> ToArrayIndex(
572                                            ^
573/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:2463:44: note:   candidate expects 1 argument, 0 provided
574In file included from ../../nan/nan.h:284:0,
575                 from ../src/drivelist.cpp:17:
576../../nan/nan_maybe_pre_43_inl.h: In function ‘Nan::Maybe<bool> Nan::Equals(v8::Handle<v8::Value>, v8::Handle<v8::Value>)’:
577../../nan/nan_maybe_pre_43_inl.h:63:32: warning: ‘bool v8::Value::Equals(v8::Local<v8::Value>) const’ is deprecated (declared at /home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:2481): Use maybe version [-Wdeprecated-declarations]
578   return Just<bool>(a->Equals(b));
579                                ^
444../../nan/nan_maybe_pre_43_inl.h: In function ‘Nan::MaybeLocal<v8::Object> Nan::NewInstance(v8::Handle<v8::Function>)’:
445../../nan/nan_maybe_pre_43_inl.h:68:48: error: no matching function for call to ‘v8::Function::NewInstance()’
446   return MaybeLocal<v8::Object>(h->NewInstance());
447                                                ^
448../../nan/nan_maybe_pre_43_inl.h:68:48: note: candidates are:
449In file included from /home/travis/.cache/node-gyp/10.20.1/include/node/node.h:63:0,
450                 from ../../nan/nan.h:54,
451                 from ../src/drivelist.cpp:17:
452/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3993:44: note: v8::MaybeLocal<v8::Object> v8::Function::NewInstance(v8::Local<v8::Context>, int, v8::Local<v8::Value>*) const
453   V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
454                                            ^
455/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3993:44: note:   candidate expects 3 arguments, 0 provided
456/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3996:44: note: v8::MaybeLocal<v8::Object> v8::Function::NewInstance(v8::Local<v8::Context>) const
457   V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
458                                            ^
459/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3996:44: note:   candidate expects 1 argument, 0 provided
460In file included from ../../nan/nan.h:284:0,
461                 from ../src/drivelist.cpp:17:
462../../nan/nan_maybe_pre_43_inl.h: In function ‘Nan::MaybeLocal<v8::Object> Nan::NewInstance(v8::Local<v8::Function>, int, v8::Local<v8::Value>*)’:
463../../nan/nan_maybe_pre_43_inl.h:76:58: error: no matching function for call to ‘v8::Function::NewInstance(int&, v8::Local<v8::Value>*&)’
425   return MaybeLocal<v8::Object>(h->NewInstance(argc, argv));
426                                                          ^
427../../nan/nan_maybe_pre_43_inl.h:76:58: note: candidates are:
428In file included from /home/travis/.cache/node-gyp/10.20.1/include/node/node.h:63:0,
429                 from ../../nan/nan.h:54,
430                 from ../src/drivelist.cpp:17:
431/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3993:44: note: v8::MaybeLocal<v8::Object> v8::Function::NewInstance(v8::Local<v8::Context>, int, v8::Local<v8::Value>*) const
432   V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
433                                            ^
434/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3993:44: note:   candidate expects 3 arguments, 2 provided
435/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3996:44: note: v8::MaybeLocal<v8::Object> v8::Function::NewInstance(v8::Local<v8::Context>) const
436   V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
437                                            ^
438/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3996:44: note:   candidate expects 1 argument, 2 provided
439In file included from ../../nan/nan_maybe_pre_43_inl.h:103:0,
440                 from ../../nan/nan.h:284,
441                 from ../src/drivelist.cpp:17:
442../../nan/nan_define_own_property_helper.h: In function ‘Nan::Maybe<bool> Nan::imp::DefineOwnPropertyHelper(v8::PropertyAttribute, v8::Handle<v8::Object>, v8::Handle<v8::String>, v8::Handle<v8::Value>, v8::PropertyAttribute)’:
443../../nan/nan_define_own_property_helper.h:23:32: error: ‘class v8::Object’ has no member named ‘ForceSet’
483              ? Just<bool>(obj->ForceSet(key, value, attribs))
484                                ^
485In file included from ../../nan/nan.h:284:0,
486                 from ../src/drivelist.cpp:17:
487../../nan/nan_maybe_pre_43_inl.h: In function ‘Nan::Maybe<bool> Nan::DefineOwnProperty(v8::Handle<v8::Object>, v8::Handle<v8::String>, v8::Handle<v8::Value>, v8::PropertyAttribute)’:
488../../nan/nan_maybe_pre_43_inl.h:110:65: error: no matching function for call to ‘v8::Object::GetPropertyAttributes(v8::Handle<v8::String>&)’
489   v8::PropertyAttribute current = obj->GetPropertyAttributes(key);
490                                                                 ^
491../../nan/nan_maybe_pre_43_inl.h:110:65: note: candidate is:
492In file included from /home/travis/.cache/node-gyp/10.20.1/include/node/node.h:63:0,
493                 from ../../nan/nan.h:54,
494                 from ../src/drivelist.cpp:17:
495/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3308:50: note: v8::Maybe<v8::PropertyAttribute> v8::Object::GetPropertyAttributes(v8::Local<v8::Context>, v8::Local<v8::Value>)
496   V8_WARN_UNUSED_RESULT Maybe<PropertyAttribute> GetPropertyAttributes(
497                                                  ^
498/home/travis/.cache/node-gyp/10.20.1/include/node/v8.h:3308:50: note:   candidate expects 2 arguments, 1 provided
499In file included from ../../nan/nan.h:284:0,
500                 from ../src/drivelist.cpp:17:
501../../nan/nan_maybe_pre_43_inl.h: In function ‘Nan::Maybe<bool> Nan::ForceSet(v8::Handle<v8::Object>, v8::Handle<v8::Value>, v8::Handle<v8::Value>, v8::PropertyAttribute)’:
464../../nan/nan_maybe_pre_43_inl.h:119:26: error: ‘class v8::Object’ has no member named ‘ForceSet’
465   return Just<bool>(obj->ForceSet(key, value, attribs));
466                          ^
467../../nan/nan_maybe_pre_43_inl.h: In function ‘Nan::Maybe<v8::PropertyAttribute> Nan::GetPropertyAttributes(v8::Handle<v8::Object>, v8::Handle<v8::Value>)’:
468../../nan/nan_maybe_pre_43_inl.h:137:68: error: no matching function for call to ‘v8::Object::GetPropertyAttributes(v8::Handle<v8::Value>&)’
469   return Just<v8::PropertyAttribute>(obj->GetPropertyAttributes(key));
470

[colin-grant-work]

In the meantime, the CI setup has been rewritten pretty completely, so I don't believe this applies anymore.