From f6cb9db61e30248388fa6692a34349651c9b2d31 Mon Sep 17 00:00:00 2001 From: Marc Dumais Date: Tue, 16 May 2023 12:56:56 -0400 Subject: [PATCH] WIP - simplifying the stub Signed-off-by: Marc Dumais --- packages/plugin-ext/src/plugin/plugin-context.ts | 4 +--- packages/plugin-ext/src/plugin/workspace.ts | 8 -------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/packages/plugin-ext/src/plugin/plugin-context.ts b/packages/plugin-ext/src/plugin/plugin-context.ts index f52d6370d3bbb..aa05e2d1ea560 100644 --- a/packages/plugin-ext/src/plugin/plugin-context.ts +++ b/packages/plugin-ext/src/plugin/plugin-context.ts @@ -729,9 +729,7 @@ export function createAPIFactory( * event should never fire. This should minimally satisfy vscode built-in extensions that decide * to use this proposed API. */ - get onWillCreateEditSessionIdentity(): theia.Event { - return workspaceExt.onWillCreateEditSessionIdentityEvent; - } + onWillCreateEditSessionIdentity: () => Disposable.create(() => {} ), }; const onDidChangeLogLevel = new Emitter(); diff --git a/packages/plugin-ext/src/plugin/workspace.ts b/packages/plugin-ext/src/plugin/workspace.ts index 7912d3e905ce0..a768cf4006da9 100644 --- a/packages/plugin-ext/src/plugin/workspace.ts +++ b/packages/plugin-ext/src/plugin/workspace.ts @@ -60,14 +60,6 @@ export class WorkspaceExtImpl implements WorkspaceExt { private didGrantWorkspaceTrustEmitter = new Emitter(); public readonly onDidGrantWorkspaceTrust: Event = this.didGrantWorkspaceTrustEmitter.event; - private willCreateEditSessionIdentityEmitter = new Emitter(); - /** - * @stubbed - * This is a stub implementation, lacking a Session Identity server/service, and so the event - * should never fire - */ - public readonly onWillCreateEditSessionIdentityEvent: Event = this.willCreateEditSessionIdentityEmitter.event; - constructor(rpc: RPCProtocol, private editorsAndDocuments: EditorsAndDocumentsExtImpl, private messageService: MessageRegistryExt) {