Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin-contributed view context menu items pollute other plugins' views #11264

Closed
colin-grant-work opened this issue Jun 6, 2022 · 1 comment · Fixed by #11290
Closed

Plugin-contributed view context menu items pollute other plugins' views #11264

colin-grant-work opened this issue Jun 6, 2022 · 1 comment · Fixed by #11290
Assignees
@colin-grant-work
Labels
plug-in system issues related to the plug-in system

Comments

@colin-grant-work
Copy link
Contributor

Steps to Reproduce:

  1. Install GitLens.
  2. Open the (built-in) NPM view.
  3. Check the ... context menu in the NPM view title.
  4. Observe that it contains many items from GitLens:

image

  1. Right-click an item in the NPM view's tree.
  2. Observe that that context menu also shows many items from GitLens:

image

Additional Information

  • Operating System: OS X
  • Theia Version: 96a3950
@colin-grant-work colin-grant-work added the plug-in system issues related to the plug-in system label Jun 6, 2022
@colin-grant-work
Copy link
Contributor Author

There's a good chance that we're ignoring the when clauses for submenus.

@colin-grant-work colin-grant-work self-assigned this Jun 13, 2022
@colin-grant-work colin-grant-work mentioned this issue Jun 13, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-grant-work colin-grant-work

Labels
plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor PluginMenuContributionHandler colin-grant-work/theia
1 participant
@colin-grant-work