onFocusChange setting is not respected

[anavarre]

Bug Description:

When configurating Theia to automatically save onFocusChange, it is expected that the Auto Save Delay setting will not have any effect since it is written very clearly that this setting gets applied only when Auto Save is set to afterDelay.

However, it seems this is not respected as you can see in the GIF file below.

Steps to Reproduce:

1. Configure Auto Save to be OnFocusChange
2. Set a high value for Auto Save Delay, e.g. 10000 to observe your file is never changed before 10 seconds, even when you change focus and expect the file to be saved then.
3. Continue playing with the Auto Save Delay value until you get convinced it is indeed not respecting the promise that onFocusChange should take precedence and Auto Save Delay should only be enforced when the Auto Save is set to afterDelay.

Additional Information

• Operating System: Ubuntu Xenial (with ESM)
• Theia Version: 1.26

[colin-grant-work]

I believe that this is a duplicate of #10812.

[anavarre]

I did stumble upon #10812 before filing this issue but it didn't seem specifically related to it at first sight.

[colin-grant-work]

I did stumble upon #10812 before filing this issue but it didn't seem specifically related to it at first sight.

Yes, my fault - it's an issue more for internal consumption than public clarity. I'll update the headline to be clearer.

[vince-fugnitto]

Closing in favor of #10812.