Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: add full support for Diagnostic.code #11659

Closed
vince-fugnitto opened this issue Sep 12, 2022 · 0 comments · Fixed by #11765 · May be fixed by EstFoisy/theia#2
Closed

vscode: add full support for Diagnostic.code #11659

vince-fugnitto opened this issue Sep 12, 2022 · 0 comments · Fixed by #11765 · May be fixed by EstFoisy/theia#2
Labels
vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

The framework currently only has partial support for Diagnostic.code:

/**
* A code or identifier for this diagnostics. Will not be surfaced
* to the user, but should be used for later processing, e.g. when
* providing {@link CodeActionContext code actions}.
*/
code?: string | number;

We should update to have full support according to the VS Code API:

/**
 * A code or identifier for this diagnostic.
 * Should be used for later processing, e.g. when providing {@link CodeActionContext code actions}.
 */
code?: string | number | {
    /**
     * A code or identifier for this diagnostic.
     * Should be used for later processing, e.g. when providing {@link CodeActionContext code actions}.
     */
    value: string | number;

    /**
     * A target URI to open with more information about the diagnostic error.
     */
    target: Uri;
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
1 participant