-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode: add tab
related apis
#11692
Comments
@vince-fugnitto can you help me though implementing these things? |
@b4s36t4 the change is pretty significant but if you want more details you can take a look at https://github.com/eclipse-theia/theia/blob/master/doc/Plugin-API.md. If you want to work on these APIs or any API please don't hesitate to ask specific questions. |
https://github.com/eclipse-theia/theia/tree/master/packages/plugin-ext |
@b4s36t4 given you're new to the project I'd maybe suggest a simpler API to start, you can take a look at #11683 if you'd like or any API that looks interesting. If you want to have discussions throughout your implementation you can create a discussion where I can respond without adding noise to the original issue. |
@b4s36t4 and @vince-fugnitto, if you don't mind I would assign myself to this one. |
@jbicker Do you have an update about this? It would be super great if you find the time to contribute to this! |
@JonasHelming Not yet. Sorry! I will continue soon. |
Just a note: Maybe you want to stub the API first, so that it is already in place? We did the same for Notebook and the test API for now and it is rather low effort. |
I'll have to check again, but I think I've already done that. I've been stuck with the implementation of the functionality behind the API. So, I can split that up. |
That sounds great! |
@jbicker Is there a chance the real impl makes it into the Jan release? |
@JonasHelming I think there is a chance. But I wouldn't promise. |
Btw. what is the release date? |
Jan 26th |
So far I implemented the functions to close tabs and tabgroups. See d5c9423 |
Feature Description:
The goal is to add support for
tab
related VS Code APIs including:Tab
TabChangeEvent
TabGroup
TabGroupChangeEvent
TabGroups
TabInputCustom
TabInputNotebook
TabInputNotebookDiff
TabInputTerminal
TabInputText
TabInputTextDiff
TabInputWebview
The text was updated successfully, but these errors were encountered: