Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Selection QuickPick for Debug 'Add Configuration' ignores focus out #11992

Closed
colin-grant-work opened this issue Dec 13, 2022 · 0 comments · Fixed by #12046
Closed
Labels
bug bugs found in the application core issues related to the core of the application debug issues that related to debug functionality ui/ux issues related to user interface / user experience

Comments

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Dec 13, 2022

Bug Description:

In #11444, ignoreFocusOut was added to the options for the workspace selection quick pick for adding debug configurations. That produces a bad UX because no other quickpicks inside the application ignore focus out.

The code was added to address a bug that was present prior to that change: clicking 'Add Configuration' in the DebugConfigurationSelect would open and then immediately close the quick pick. That is a problem with the ReactSelectComponent - because it removes the cotainer for rendering options, it triggers a blur event with relatedTarget: null. The problem should be addressed there rather than worked around in the debug package.

Steps to Reproduce:

  1. Open a multi-root workspace.
  2. Open the debug view and use the dropdown to select 'Add Configuration'
  3. See a quickpick.
  4. Try to get out of the quick pick by focusing other elements.
  5. Observe that the quick pick remains.

  1. Remove the ignoreFocusOut: true from the options in the DebugConfigurationManager
  2. Follow steps 1-2 above.
  3. Observe that the quickpick appears and then immediately disappears.

Additional Information

  • Operating System: Windows 10, Electron
  • Theia Version: ac7a9ff
@colin-grant-work colin-grant-work added debug issues that related to debug functionality core issues related to the core of the application ui/ux issues related to user interface / user experience bug bugs found in the application labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application core issues related to the core of the application debug issues that related to debug functionality ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant