Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[License] Inaccurate mentions of secondary license name and SPDX #12583

Closed
marcdumais-work opened this issue May 31, 2023 · 0 comments · Fixed by #12584
Closed

[License] Inaccurate mentions of secondary license name and SPDX #12583

marcdumais-work opened this issue May 31, 2023 · 0 comments · Fixed by #12584
Assignees

Comments

@marcdumais-work
Copy link
Contributor

marcdumais-work commented May 31, 2023

Bug Description:

@SpessartZiegler recently reported a couple problems with our licenses:

  • We have had the SPDX wrong for our secondary license [1]. Also in places, we have that license name wrong. I checked for the primary license (EPL) and found no similar issues with our naming/referencing it. update: Wayne confirmed that the current SPDX is not perfect but better than the deprecated version.
  • When we recently split the license file into two, the text of the secondary license got accidently changed, e.g. now it contains an extra, Oracle-specific pargraph. We should re-align on the official license text.

In addition, I think that the naming of the LICENSE-GPL file is likely to cause confusion and that a name that's more in-line with the fact that the secondary license is specifically the "classpath exception" variant, would be an improvement.

Some more details:

In the package.json files and in the header of source files, we have the SPDX[1], and a slightly better one suggested by Wayne :

  • current: SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  • better: SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0

Links:

Steps to Reproduce:

Additional Information

  • Operating System:
  • Theia Version:
@marcdumais-work marcdumais-work changed the title [License] we have inaccurate mentions of license name and SPDX [License] we have inaccurate mentions of secondary license name and SPDX May 31, 2023
@marcdumais-work marcdumais-work changed the title [License] we have inaccurate mentions of secondary license name and SPDX [License] Inaccurate mentions of secondary license name and SPDX May 31, 2023
@marcdumais-work marcdumais-work self-assigned this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant