Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.tabbar.enhancedPreview #14343

Open
Tracked by #13192
XeonG opened this issue Oct 21, 2024 · 1 comment
Open
Tracked by #13192

window.tabbar.enhancedPreview #14343

XeonG opened this issue Oct 21, 2024 · 1 comment

Comments

@XeonG
Copy link

XeonG commented Oct 21, 2024

Seems this feature is a little broken and could do with some extra settings

If you look at the preview of a a file that is a git commit comparison for an uncommited file with nothing to compare against, you will see the hover broken.. image shows the issue...

TheiaIDE_UZkEqd9l9b

Settings
-Show Visual Preview even on the current opened tab.. its not smart not showing the image just abeuse its already opened.. if you're sliding across tabs you expect things to be in the same layout and height.. have the things all shifted and a missing image on hover over an active tab just makes the text for extra path settings shift... frankly it shouldn't hide the image, just show it or make the open to not show it the default.

-Image thumbnail size, small/medium/large... I think the current size is fine but sizing opens are always better to have with different desktop resolutions.

Operating System: win10
Theia Version: Version 1.54.0
VS Code API Version: 1.93.1

@JonasHelming JonasHelming transferred this issue from eclipse-theia/theia-ide Oct 22, 2024
@JonasHelming
Copy link
Contributor

Thank you for the report!

Steps to reproduce:

  • window.tabbar.enhancedPreview setting to "visual"
  • Create a new file in a git repo
  • Double click the new file in the SCM view to open the comparison (only showing the new file content
  • Observe hover is at the wrong position (as shown above)

@JonasHelming JonasHelming mentioned this issue Oct 29, 2024
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants