-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[electron] Upgrade electron to version 3.x.x #3729
Comments
VS Code are planning on moving to electron 3.x in Q1 2019: |
Upgrading to node 10 would also fix #2009 |
This now works on the electron-3 branch. Tests are yet to pass, however. |
Hi This would also fix electron/electron#15194 which was merged in Electron but backported only to 3.x and 4.x versions. I created #4736 to use the latest 3.x version of Electron. @thegecko : do you have an ETA for this issue ? |
@debovema what timescales are you working to? I'm happy to update the branch to get it working again and open a PR for discussion with the rest of the team. My issue was getting the tests passing, would you be able to help with that? |
I am mainly targeting a browser app but having an Electron app would be good on the long-term. I will try to run the tests and see what's wrong. |
Fixed |
In order to take advantage of updates and security fixes in electron, we should upgrade to the latest version of 3.x.x (currently 3.0.10).
This would target the following sub-product versions:
10.2.0
66
6.6
We should also update the minimum node version used by Theia to match the above (
>=10.2.0
).According to node.green this update would then allow support of all
ES2015
language features.Note: This should be done inline with VS Code's support for electron.
The text was updated successfully, but these errors were encountered: