Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron] Upgrade electron to version 3.x.x #3729

Closed
thegecko opened this issue Dec 4, 2018 · 7 comments
Closed

[electron] Upgrade electron to version 3.x.x #3729

thegecko opened this issue Dec 4, 2018 · 7 comments
Assignees
Labels
electron issues related to the electron target enhancement issues that are enhancements to current functionality - nice to haves

Comments

@thegecko
Copy link
Member

thegecko commented Dec 4, 2018

In order to take advantage of updates and security fixes in electron, we should upgrade to the latest version of 3.x.x (currently 3.0.10).

This would target the following sub-product versions:

  • Node > 10.2.0
  • Chrome > 66
  • V8 > 6.6

We should also update the minimum node version used by Theia to match the above (>=10.2.0).

According to node.green this update would then allow support of all ES2015 language features.

Note: This should be done inline with VS Code's support for electron.

@thegecko thegecko added the electron issues related to the electron target label Dec 4, 2018
@thegecko thegecko self-assigned this Dec 4, 2018
@thegecko
Copy link
Member Author

thegecko commented Dec 7, 2018

VS Code are planning on moving to electron 3.x in Q1 2019:

microsoft/vscode#52629 (comment)

@thegecko
Copy link
Member Author

thegecko commented Dec 7, 2018

Upgrading to node 10 would also fix #2009

@thegecko
Copy link
Member Author

thegecko commented Dec 7, 2018

This now works on the electron-3 branch.

Tests are yet to pass, however.

@thegecko thegecko added the enhancement issues that are enhancements to current functionality - nice to haves label Feb 14, 2019
@debovema
Copy link
Contributor

debovema commented Mar 27, 2019

Hi

This would also fix electron/electron#15194 which was merged in Electron but backported only to 3.x and 4.x versions.

I created #4736 to use the latest 3.x version of Electron.

@thegecko : do you have an ETA for this issue ?

@thegecko
Copy link
Member Author

@debovema what timescales are you working to? I'm happy to update the branch to get it working again and open a PR for discussion with the rest of the team.

My issue was getting the tests passing, would you be able to help with that?

@debovema
Copy link
Contributor

I am mainly targeting a browser app but having an Electron app would be good on the long-term.

I will try to run the tests and see what's wrong.

@thegecko
Copy link
Member Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

No branches or pull requests

2 participants