Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plug-in] Code lens feature doesn't work correctly #3946

Closed
svor opened this issue Jan 4, 2019 · 2 comments
Closed

[plug-in] Code lens feature doesn't work correctly #3946

svor opened this issue Jan 4, 2019 · 2 comments
Assignees
@svor
Labels
bug bugs found in the application plug-in system issues related to the plug-in system

Comments

@svor
Copy link
Contributor

svor commented Jan 4, 2019

Code lenses are not displayed when trying to run vscode-jsva extension as a plugin in Theia.
Looks like command-registry:CommandsConverter works incorrectly.
@svor svor added bug bugs found in the application plug-in system issues related to the plug-in system labels Jan 4, 2019
@svor svor self-assigned this Jan 4, 2019
@tsmaeder
Copy link
Contributor

tsmaeder commented Jan 4, 2019

@svor do you have any more info on what is wrong with the CommandConverter?

@svor
Copy link
Contributor Author

svor commented Jan 4, 2019

@tsmaeder
CommandsConverter wants to convert the command from CodeLens to internal command model:Command but the structure of CodeLens.Command is not the same as theia:Command

@tsmaeder tsmaeder mentioned this issue Jan 8, 2019
Closed
16 tasks
This was referenced Jan 8, 2019
Closed
Closed
Merged
@tsmaeder tsmaeder mentioned this issue Jan 15, 2019
Closed
30 tasks
@svor svor closed this as completed Jan 22, 2019
@tsmaeder tsmaeder mentioned this issue Feb 8, 2019
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svor svor

Labels
bug bugs found in the application plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svor @tsmaeder