Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] support octicon in the status-bar text #4005

Closed
akosyakov opened this issue Jan 10, 2019 · 4 comments · Fixed by #5416
Closed

[plugin] support octicon in the status-bar text #4005

akosyakov opened this issue Jan 10, 2019 · 4 comments · Fixed by #5416
Assignees
@akosyakov
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager statusbar issues related to the statusbar

Comments

@akosyakov
Copy link
Member

https://code.visualstudio.com/api/references/vscode-api#StatusBarItem

@svenefftinge Would it be fine to include next to fontawesome icons?
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system statusbar issues related to the statusbar labels Jan 10, 2019
@vazexqi
Copy link

vazexqi commented Mar 21, 2019

Piggy backing onto this bug since it seems related, I can open a new one if you want.

We are experimenting with using .vsix in Theia. We have noticed that icons (octicons) in labels are supported in VS Code per https://code.visualstudio.com/api/references/icons-in-labels

However, this currently doesn't work consistently in Theia. It works on the status bar in Theia but not in the quick pick. See the attached screenshot.

Screen Shot 2019-03-21 at 7 08 48 AM

The $(plus) should be the + symbol in octicons.

@akosyakov
Copy link
Member Author

yes, we should support it

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Mar 21, 2019
@akosyakov akosyakov added scm issues related to the source control manager git issues related to git labels Jun 10, 2019
@akosyakov
Copy link
Member Author

It's required fro scm as well to show status bar icons from git extension.

@akosyakov akosyakov self-assigned this Jun 10, 2019
@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Jun 10, 2019
@akosyakov akosyakov mentioned this issue Jun 10, 2019
Closed
@akosyakov
Copy link
Member Author

@vazexqi extracted #5412 for your issue

@akosyakov akosyakov mentioned this issue Jun 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager statusbar issues related to the statusbar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rework scm, recover git extension eclipse-theia/theia
2 participants
@vazexqi @akosyakov