Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plug-in]Apply code action does not work #4081

Closed
svor opened this issue Jan 16, 2019 · 1 comment
Closed

[plug-in]Apply code action does not work #4081

svor opened this issue Jan 16, 2019 · 1 comment
Labels
plug-in system issues related to the plug-in system

Comments

@svor
Copy link
Contributor

svor commented Jan 16, 2019

While using java VS Code extension I found that ApplayCodeAction command does not work.
Looks like this issue related to commands API. Here I see 2 problems:

  1. When a command from code action is transforming to internal Command by https://github.com/theia-ide/theia/blob/master/packages/plugin-ext/src/plugin/type-converters.ts#L404. The problem is here
    because Command from vscode.d.ts is not identical with Command from theia.d.ts.

  2. There are no way to register a command from the plugin as global. By global i mean that registered command should be available not only in plugin-system. It means that commands which were provided by plugins will be visible in Theia scope to make it possible execute them.

@svor svor added the plug-in system issues related to the plug-in system label Jan 16, 2019
@svor
Copy link
Contributor Author

svor commented Jan 22, 2019

Fixed by #4021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

1 participant