Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question][file-search] Unexpected recently opened items in the file search #4468

Open
kittaakos opened this issue Mar 2, 2019 · 7 comments
Labels
file search issues related to the file search

Comments

@kittaakos
Copy link
Contributor

As a user I would expect the following behavior:

  • I press Ctrl/Cmd+P.
  • The input field is empty; hence I see the recent items only.
  • I type task and I don't see recent items that don't match the query term.

Q: is this a bug or the desired behavior?

The file results are correct.

screen shot 2019-03-02 at 13 30 25

@kittaakos kittaakos added question user / developer questions file search issues related to the file search labels Mar 2, 2019
@vince-fugnitto
Copy link
Member

@kittaakos it looks odd to me too, we seem to pick up recent matches that don't really belong based on the query term.

@vince-fugnitto
Copy link
Member

@kittaakos I tested the recently opened by trying to have the same items as you. I don't notice the same behavior you had mentioned in the issue.

My recently opened list:

screen shot 2019-03-03 at 7 05 54 pm

When searching for task:

screen shot 2019-03-03 at 7 06 08 pm

@kittaakos
Copy link
Contributor Author

This is still an issue with 59451b8.

Screen Shot 2019-03-26 at 08 35 45

@akosyakov
Copy link
Member

59451b8 does not seem to be related?

@vince-fugnitto
Copy link
Member

I am unable to reproduce the following issue, perhaps it has been fixed?

@DucNgn
Copy link
Contributor

DucNgn commented Nov 12, 2020

@vince-fugnitto I don't think it has been fixed

image

@vince-fugnitto
Copy link
Member

The issue is that fuzzy currently matches too easily:

fuzzy.match("os.ts", "packages/core/src/common/resource.ts", { pre: "/", post: "\/" });
=> Object {rendered: "packages/c/o/re//s/rc/common/resource/.//t//s/", score: 13}
fuzzy.test("os.ts", "packages/core/src/common/resource.ts");
=> true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file search issues related to the file search
Projects
None yet
Development

No branches or pull requests

4 participants