Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS][keybinding] Use ⌘ instead of Cmd as the accelerator on macOS #5427

Open
kittaakos opened this issue Jun 12, 2019 · 1 comment
Open

[macOS][keybinding] Use ⌘ instead of Cmd as the accelerator on macOS #5427

kittaakos opened this issue Jun 12, 2019 · 1 comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings OS/Mac issues related to Mac OS ui/ux issues related to user interface / user experience

Comments

@kittaakos
Copy link
Contributor

This is UI/UX only. Originally from here: #5416 (comment)

Update:
https://github.com/theia-ide/theia/blob/819ebfe103493ba87e2e5706eb6a54bc4364aecc/packages/core/src/browser/keybinding.ts#L336

Add:
https://github.com/theia-ide/theia/blob/819ebfe103493ba87e2e5706eb6a54bc4364aecc/packages/core/src/browser/keyboard/keys.ts#L454
@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings OS/Mac issues related to Mac OS ui/ux issues related to user interface / user experience labels Jun 12, 2019
@kittaakos kittaakos mentioned this issue Jun 12, 2019
Merged
@vince-fugnitto
Copy link
Member

Consequently, is this the reason meta is displayed instead of cmd in the keybindings-widget on macOS?

Screen Shot 2019-06-19 at 12 58 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings OS/Mac issues related to Mac OS ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittaakos @vince-fugnitto