Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] complete scm API #5458

Closed
10 tasks
akosyakov opened this issue Jun 13, 2019 · 1 comment
Closed
10 tasks

[vscode] complete scm API #5458

akosyakov opened this issue Jun 13, 2019 · 1 comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Jun 13, 2019 •
edited
Loading

Somehow we have declared or even some implementation of vscode SCM api which is never used actually in Theia. It should be properly connected:

  • QuickDiffProvider.provideOriginalResource
  • SourceControl.count
  • SourceControl.commitTemplate
  • SourceControlResourceGroup.hideWhenEmpty
  • SourceControlResourceDecorations.strikeThrough
  • SourceControlResourceDecorations.faded
  • SourceControlResourceDecorations.iconPath - it is supported but bogusly. It works only for absolute paths. It should be properly turned into an icon URL as for other plugins icons and support different themes. Look like it is done for the tree views.

Proposed:

  • SourceControlInputBox.validateInput - it is used by git vscode extension
  • SourceControl.selected + SourceControl.onDidChangeSelection - it is used by git vscode extension
  • SourceControlInputBox.visible
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager vscode issues related to VSCode compatibility labels Jun 13, 2019
@planger planger mentioned this issue May 12, 2022
Closed
@tsmaeder
Copy link
Contributor

Superseeded

@msujew msujew closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @msujew @tsmaeder