repository does not always shows up in the git diff view in a multi root workspace

[elaihau]

Description

The repository does not always shows up in the git diff view in a multi root workspace.

Reproduction Steps

• Open a folder as the workspace
• Add one more folder to make a multi root workspace
• Right click one folder from the 2nd root -> Compare With ... -> Open the diff view
  • Name of the Repository shows up in the view
• Right click one folder from the 1st root -> Compare With ... -> Open the diff view
  • Name of the Repository does not show up in the view

Result: Repository shows up in the diff view for one root, not the other
Expected: If the repository shows up for one root, it should also show up for the other root.

See GIF below:

OS and Theia version:
Ubuntu 18.04, example browser, master branch as of Aug 20, 2019.

[elaihau]

I did some investigation.
Looks like the inconsistency is by design:
https://github.com/theia-ide/theia/blob/c1d367f30333113423689af9344a4c7e8e15579d/packages/git/src/browser/git-navigable-list-widget.tsx#L89

If the diff is not based on the active / selected git repo, the Repository row is rendered, otherwise the row does not show up.

Maybe we should close this one? @jbicker @akosyakov @vince-fugnitto

[elaihau]

I am closing this one, and if there are objections please free feel to reopen.