Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract webview extension #6562

Open
akosyakov opened this issue Nov 16, 2019 · 1 comment
Open

extract webview extension #6562

akosyakov opened this issue Nov 16, 2019 · 1 comment
Labels
mini-browser issues related to the mini-browser proposal feature proposals (potential future features) webviews issues related to webviews

Comments

@akosyakov
Copy link
Member

akosyakov commented Nov 16, 2019

Webview is an abstraction to load remote content in the safe way. #6465 brings its support to the plugin system only. It is a proposal to extract it to own extension to reuse by Theia extensions. There are many benefits beside security:

  • links to localhost resolved to remote centrally for the whole application by ExternalUriService.resolve
  • good integration with the shell out of the box, storing/restoring widget
  • focus tracking, styling, keyboard propagataion, scrolling preservation between drag and drops and so on.

The good candidate to use it will be mini-browser, which is suffering from similar security and functionality issues. Generally whenever someone thinks he needs to load remote content with iframe, they should better to use webviews.

cc @svenefftinge

@akosyakov akosyakov added mini-browser issues related to the mini-browser proposal feature proposals (potential future features) webviews issues related to webviews labels Nov 16, 2019
@progrium
Copy link

I'm into this. Tell me how I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mini-browser issues related to the mini-browser proposal feature proposals (potential future features) webviews issues related to webviews
Projects
None yet
Development

No branches or pull requests

2 participants