Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label updates are not refreshed in mini browser props #6596

Open
westbury opened this issue Nov 20, 2019 · 0 comments
Open

Label updates are not refreshed in mini browser props #6596

westbury opened this issue Nov 20, 2019 · 0 comments
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves mini-browser issues related to the mini-browser

Comments

@westbury
Copy link
Contributor

Description

This is a follow-on issue from #5884 as per @akosyakov's comment #5884 (review)

Props of the mini browser are not updated if they are computed from the label provider. W probably should handle it here: https://github.com/westbury/theia/blob/59b4ad001e6f57cb823dab56a23cdb32a4c50868/packages/mini-browser/src/browser/mini-browser-open-handler.ts#L126 It could be a bit tricky, since we should not do it when name and iconClass provided. It would be good to have a follow-up issue at least.

Reproduction Steps

With #5884 included, run the 'Examples: Toggle Dynamically-Changing Labels' command. View properties of the mini browser (in case where they are not provided so label provider is used). Use URI that contains 'test' in it. Check that a increasing numeric suffix is prepended.

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves mini-browser issues related to the mini-browser labels Nov 21, 2019
@akosyakov akosyakov self-assigned this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves mini-browser issues related to the mini-browser
Projects
None yet
Development

No branches or pull requests

2 participants