Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputChannel.show() no longer reveals output channel #7383

Closed
tetchel opened this issue Mar 20, 2020 · 2 comments
Closed

outputChannel.show() no longer reveals output channel #7383

tetchel opened this issue Mar 20, 2020 · 2 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help output issues related to the output plug-in system issues related to the plug-in system

Comments

@tetchel
Copy link
Contributor

tetchel commented Mar 20, 2020

Description

outputChannel.show() no longer works. I believe this is a regression (see Theia versions below).

The output channel is created, but the Output view is not opened, and the channel is not brought to the front of the Output view. This means that calling show on an existing output channel has no effect.

Reproduction Steps

I've created a repository with a plugin (source and vsix) that you can reproduce with: https://github.com/tetchel/theia-output-show-bug

OS and Theia version:
I see the issue in Theia 0.15, 0.16, 0.16.1, and master branch.
I do NOT see the issue in theia 0.14, it works as expected.

Diagnostics:

I see this in the logs:
root WARN Widget was activated, but did not accept focus after 2000ms: outputView

@tetchel tetchel changed the title outputChannel.show() no longer works outputChannel.show() no longer reveals output channel Mar 20, 2020
@kittaakos kittaakos added the plug-in system issues related to the plug-in system label Mar 20, 2020
@vince-fugnitto vince-fugnitto added the output issues related to the output label Mar 20, 2020
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help labels Mar 20, 2020
@akosyakov
Copy link
Member

@tetchel Could you check against #7570 please? The output view was completely reimplemented for better performance and user interactions.

@tetchel
Copy link
Contributor Author

tetchel commented Jun 3, 2020

It is fixed in master 👍

@tetchel tetchel closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help output issues related to the output plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

4 participants