[git-scm] No repository found

[502647092]

Bug Description:

• I manually add paths to local storage theia:/:file:///home/project:theia-git-all-repositories
• refresh ide Can fix it
  
  

Steps to Reproduce:

1. build latest theia
2. open a WorkSpace have multi git repo

Additional Information

• Operating System: Windows10
• Theia Version: 1.2.0-next.f97ec33e

[vince-fugnitto]

Duplicate of #4107?
You can try using the git and git-ui builtin extensions and determining if the use-case is handled correctly (@theia/git will be deprecated in the near future).

[502647092]

@vince-fugnitto

also have this problem

[westbury]

This is a regression caused by ecdb151 . With the typescript upgrade, the locator is no longer returning the repositories.

The problem is caused by the change of this line:

if (stat.isDirectory) {
to
if (stat.isDirectory()) {

The original line was always true, so the code inside the 'if' was executed for files. Executing the code only for directories results in repositories not being returned.

[502647092]

another problem if ide reconnect backend the git info will lose

[westbury]

@502647092 I have pushed a fix to branch fix-locate-repos. Can you test with this branch to see if it fixes the issues?