Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a new file in a diff editor from the GIT SCM does not open #7961

Open
lmcbout opened this issue Jun 4, 2020 · 2 comments
Open

Open a new file in a diff editor from the GIT SCM does not open #7961

lmcbout opened this issue Jun 4, 2020 · 2 comments
Labels
bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help scm issues related to the source control manager

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Jun 4, 2020

Bug Description:

Selecting a new File in SCM GIT view (File with an "A" on the right side, not a "M" for Modified), it generates an error and the file does not open in the diff editor. If you select the same file but try to use the "Open File" instead, no error are generated. VScode open the file in the diff editor.

Steps to Reproduce:

  1. Open SCM view
  2. Select a new File (One with a "A", not a modified file) Or create a new file in your workspace to have this file available as a new file
  3. Left Click on your mouse to open the file in a diff editor
    --> Observe the popup Dialog with the error: Git: Cannot read property 'uri' of undefined
    --> Look at VScode: It open the diff editor

THEIA
GitViewDiffForNewFiles

VSCODE
VSCodeGitDiff

Additional Information

  • Operating System: Ubuntu 18.04
  • Theia Version: Latest
  • Git + Git-UI version: 1.39.1
@akosyakov akosyakov added bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help scm issues related to the source control manager labels Jun 5, 2020
@lmcbout
Copy link
Contributor Author

lmcbout commented Jun 5, 2020

In addition to the description, selecting an Untracked File in SCM GIT view (File with an "U" on the right side), it generates an error. So it seems the only file we can open is the Modified files ("M") and the deleted files ("D")

@datou0412
Copy link
Contributor

Open a deleted file generates an error too
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application git issues related to git help wanted issues meant to be picked up, require help scm issues related to the source control manager
Projects
None yet
Development

No branches or pull requests

3 participants