Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html: builtin displays an error notification #7987

Closed
vince-fugnitto opened this issue Jun 10, 2020 · 7 comments
Closed

html: builtin displays an error notification #7987

vince-fugnitto opened this issue Jun 10, 2020 · 7 comments
Labels
bug bugs found in the application builtins Issues related to VS Code builtin extensions help wanted issues meant to be picked up, require help html Issues related to HTML functionality

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

Following #7972, the vscode-builtin-html-language-features displays an error notification when a html file is opened. Originally commented: #7972 (review)

Screenshot from 2020-06-10 07-57-38

Steps to Reproduce:

I reproduced the issue in the following way:

  1. start the application
  2. create a new html file, ex: a.html
  3. the error is displayed
@vince-fugnitto vince-fugnitto added builtins Issues related to VS Code builtin extensions html Issues related to HTML functionality labels Jun 10, 2020
@kittaakos
Copy link
Contributor

Another issue was logged here:

  • Open a HTML file:
root INFO [hosted-plugin: 10818] PLUGIN_HOST(10818): PluginManagerExtImpl/loadPlugin(/Users/akos.kitta/git/theia/plugins/vscode-builtin-npm/extension/dist/main)
root ERROR [hosted-plugin: 10818] Promise rejection not handled in one second: TypeError: s.SemanticTokensLegend is not a constructor , reason: TypeError: s.SemanticTokensLegend is not a constructor
root ERROR [hosted-plugin: 10818] With stack trace: TypeError: s.SemanticTokensLegend is not a constructor
   at b.sendRequest.then.e (/Users/akos.kitta/git/theia/plugins/vscode-builtin-html-langua

@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help labels Jun 10, 2020
@vince-fugnitto
Copy link
Member Author

@akosyakov
Copy link
Member

But experience is bad, we should either try a version before or port the implementation. I am not sure whether it is possible, maybe a new version of Monaco is required, not even 0.20 but newer.

@shahar-h
Copy link
Contributor

Error notification is not displayed with 1.39.1, but rename is not supported there.
All other features are working according to the tests in #7972.

@akosyakov
Copy link
Member

Confirmed we need a new Monaco version which was not even yet published.

@a1994846931931
Copy link
Contributor

I can confirm that the latest version (1.47.1) of HTML Language Features (built-in) works fine with Theia.

@vince-fugnitto
Copy link
Member Author

Closed thanks to #8224.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application builtins Issues related to VS Code builtin extensions help wanted issues meant to be picked up, require help html Issues related to HTML functionality
Projects
None yet
Development

No branches or pull requests

5 participants