Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environmentVariableCollection to PluginContext #8405

Closed
vinokurig opened this issue Aug 19, 2020 · 6 comments · Fixed by #8523
Closed

Add environmentVariableCollection to PluginContext #8405

vinokurig opened this issue Aug 19, 2020 · 6 comments · Fixed by #8523
Assignees
@vinokurig
Labels
plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team vscode issues related to VSCode compatibility

Comments

@vinokurig
Copy link
Contributor

Recently environmentVariableCollection was added to vscode plugin API by microsoft/vscode@af3c79e.

Feature Description:

Need to align theia's PluginContext with ExtensionContext from vscode. It is needed to use the latest vscode git extension: https://github.com/microsoft/vscode/blob/5185d7e6f8a1ca1c5e03f21d62f0a113d234a95d/extensions/git/src/terminal.ts#L20
@vinokurig vinokurig added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Aug 19, 2020
@akosyakov
Copy link
Member

@vinokurig Could you elaborate which extensions are using it please?

@vinokurig
Copy link
Contributor Author

The built-in vscode Git extension uses it since 1.45.0: https://github.com/microsoft/vscode/blob/d69a79b73808559a91206d73d7717ff5f798f23c/extensions/git/src/terminal.ts#L20-L24

@ericwill ericwill mentioned this issue Aug 20, 2020
Closed
32 tasks
@vinokurig vinokurig self-assigned this Sep 2, 2020
@ericwill ericwill mentioned this issue Sep 10, 2020
Closed
29 tasks
@amiramw
Copy link
Member

amiramw commented Sep 14, 2020

@vinokurig are you working on this issue any time soon or we can try?

@vinokurig
Copy link
Contributor Author

@amiramw I am working om it right now. I am going to open a PR this week

@amiramw
Copy link
Member

amiramw commented Sep 14, 2020

@vinokurig That's great. Do you know if this the only gap in order to support builtin git?

@vinokurig
Copy link
Contributor Author

It is already possible to use the vscode git version 1.44.2. This is needed to use later versions.

@vinokurig vinokurig mentioned this issue Sep 18, 2020
Merged
1 task
@vinokurig vinokurig added the Team: Che-Plugins issues related to the che-plugins team label Oct 1, 2020
@ericwill ericwill mentioned this issue Oct 1, 2020
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add environmentVariableCollection to PluginContext eclipse-theia/theia
3 participants
@akosyakov @vinokurig @amiramw